do not use com.sun.* classes
Description
Environment
Attachments
- 08 Nov 2013, 02:13 PM
Activity
Tom Evans November 14, 2014 at 11:51 PM
Refactored to remove deprecated dependencies.
Daryl Herzmann November 14, 2014 at 5:49 PM
Created PR to revert most of this patch https://github.com/igniterealtime/Openfire/pull/111
Daryl Herzmann November 14, 2014 at 4:00 PM
Here was the email we got on the matter
I really appreciate that https://igniterealtime.atlassian.net/browse/OF-189#icft=OF-189 should be closed now but I have concerns
aboutorg.jivesoftware.openfire.sasl.PolicyUtils as seen in
http://fisheye.igniterealtime.org/browse/openfire/trunk/src/java/org/jivesof
tware/openfire/sasl/PolicyUtils.java?r=13807 . As far as I can see this is
just a copy of
http://cr.openjdk.java.net/~jjg/7064075/src/share/classes/com/sun/security/s
asl/util/PolicyUtils.java.html where the Oracle Copyright and GPL License is
replaced by jive Software Copyright and Apache License.Even the author "author Rosanna Lee" is still present in
org.jivesoftware.openfire.sasl.PolicyUtils. That might end in legal problems
so it might be a good idea to revert that patch.
Daryl Herzmann April 30, 2014 at 5:43 PM
Moving unfixed 3.9.2 issues to 3.9.3 for consideration.
LG March 29, 2014 at 6:53 PM
admin/index_jsp.java still uses com.sun.syndication.
com.sun.syndication.feed.synd.* is in http://download.java.net/maven/2/rome/rome/1.0/
com.sun.syndication.fetcher.* is in http://download.java.net/maven/2/rome/rome-fetcher/1.0/
Adding both JARs to Openfire should allow us to keep this reference. The IBM JRE https://www.ibm.com/developerworks/java/jdk/linux/download.html does hopefully work then without issues.
SaslServerFactoryImpl.java imports "com.sun.security.sasl.util.PolicyUtils;". This Sun class is not available on AIX and thus SASL does not work.
I wonder whether javax.security.sasl is a better choice. Scan the source code for "import com.sun." and replace these lines and also the code as needed.