Uploaded image for project: 'Openfire'
  1. Openfire
  2. OF-1592

Reduce verbosity of failure to update a vcard when read-only

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0
    • Component/s: Core
    • Labels:
      None

      Description

      VCards are managed in Openfire. A client can typically obtain and update VCards.

      The underlying VCard provider can be 'read-only' (for example, when the provider is LDAP based). If that's the case, VCards cannot be updated by clients.

      Openfire is currently logging a very verbose error when a client tries to update a VCard on a read-only system. This verbosity should be turned down a couple of notches.

      2018.08.17 09:58:46 ERROR [Jetty-QTP-BOSH-82]: org.jivesoftware.openfire.handler.IQvCardHandler - VCard provider is read-only.
      java.lang.UnsupportedOperationException: VCard provider is read-only.
              at org.jivesoftware.openfire.vcard.VCardManager.setVCard(VCardManager.java:158)
              at org.jivesoftware.openfire.handler.IQvCardHandler.handleIQ(IQvCardHandler.java:90)
              at org.jivesoftware.openfire.handler.IQHandler.process(IQHandler.java:62)
              at org.jivesoftware.openfire.IQRouter.handle(IQRouter.java:369)
              at org.jivesoftware.openfire.IQRouter.route(IQRouter.java:112)
              at org.jivesoftware.openfire.spi.PacketRouterImpl.route(PacketRouterImpl.java:74)
              at org.jivesoftware.openfire.SessionPacketRouter.route(SessionPacketRouter.java:104)
              at org.jivesoftware.openfire.SessionPacketRouter.route(SessionPacketRouter.java:63)
              at org.jivesoftware.openfire.websocket.StreamManagementPacketRouter.route(StreamManagementPacketRouter.java:61)
              at org.jivesoftware.openfire.websocket.XmppWebSocket.processStanza(XmppWebSocket.java:241)
              at org.jivesoftware.openfire.websocket.XmppWebSocket.onTextMethod(XmppWebSocket.java:115)
              at sun.reflect.GeneratedMethodAccessor54.invoke(Unknown Source)
              at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
              at java.lang.reflect.Method.invoke(Method.java:498)
              at org.eclipse.jetty.websocket.common.events.annotated.CallableMethod.call(CallableMethod.java:70)
              at org.eclipse.jetty.websocket.common.events.annotated.OptionalSessionCallableMethod.call(OptionalSessionCallableMethod.java:72)
              at org.eclipse.jetty.websocket.common.events.JettyAnnotatedEventDriver.onTextMessage(JettyAnnotatedEventDriver.java:234)
              at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
              at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
              at org.eclipse.jetty.websocket.common.events.JettyAnnotatedEventDriver.onTextFrame(JettyAnnotatedEventDriver.java:226)
              at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
              at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:308)
              at org.eclipse.jetty.websocket.common.extensions.AbstractExtension.nextIncomingFrame(AbstractExtension.java:163)
              at org.eclipse.jetty.websocket.common.extensions.compress.PerMessageDeflateExtension.nextIncomingFrame(PerMessageDeflateExtension.java:105)
              at org.eclipse.jetty.websocket.common.extensions.compress.CompressExtension.forwardIncoming(CompressExtension.java:136)
              at org.eclipse.jetty.websocket.common.extensions.compress.PerMessageDeflateExtension.incomingFrame(PerMessageDeflateExtension.java:85)
              at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
              at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
              at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
              at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
              at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
              at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
              at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
              at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
              at java.lang.Thread.run(Thread.java:748)
      

        Attachments

          Activity

            People

            Assignee:
            guus Guus der Kinderen
            Reporter:
            guus Guus der Kinderen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: