Uploaded image for project: 'Openfire'
  1. Openfire
  2. OF-1508

NPE when getting unknown Entity Caps

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0
    • Component/s: Core
    • Labels:
      None

      Description

      We shouldn't look up entity capabilities by hash, if the hash is null. The lookup will result in null, but generates nasty stack traces like this one:

      2018.03.09 14:01:50 DEBUG [pool-3-thread-1]: org.jivesoftware.util.cache.DefaultCache - Allowing storage of null within Cache: 
      java.lang.NullPointerException: Null value is not allowed!
      at org.jivesoftware.util.cache.DefaultCache.checkNotNull(DefaultCache.java:704)
      at org.jivesoftware.util.cache.DefaultCache.put(DefaultCache.java:138)
      at org.jivesoftware.util.cache.CacheWrapper.put(CacheWrapper.java:146)
      at org.jivesoftware.openfire.pep.PEPServiceManager.getPEPService(PEPServiceManager.java:82)
      at org.jivesoftware.openfire.pep.IQPEPHandler$GetNotificationsOnInitialPresence.run(IQPEPHandler.java:734)
      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
      at java.lang.Thread.run(Thread.java:748)
      

        Attachments

          Activity

            People

            • Assignee:
              dwd Dave Cridland
              Reporter:
              guus Guus der Kinderen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: