Uploaded image for project: 'Openfire'
  1. Openfire
  2. OF-1198

Improve MUC error handling (don't try to respond to responses)

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.0
    • Component/s: MUC
    • Labels:
      None

      Description

      When an entity sends an IQ stanza to a MUC, the implementation checks if the entity is in the room. If that's not the case, an error is returned. Such an error should not be generated if the original stanza is an IQ result or error.

      java.lang.IllegalArgumentException: IQ must be of type 'set' or 'get'. Original IQ: <iq from="IreplacedThisToProtectTheInnocent@conversations.im/phone" to="open_chat@conference.igniterealtime.org" type="error" id="asuqg2mi2f"><query xmlns="http://jabber.org/protocol/disco#info"><identity category="conference" name="open_chat" type="text"/><feature var="http://jabber.org/protocol/muc"/><feature var="muc_public"/><feature var="muc_open"/><feature var="muc_unmoderated"/><feature var="muc_nonanonymous"/><feature var="muc_unsecured"/><feature var="muc_persistent"/><feature var="http://jabber.org/protocol/disco#info"/><x xmlns="jabber:x:data" type="result"><field var="FORM_TYPE" type="hidden"><value>http://jabber.org/protocol/muc#roominfo</value></field><field var="muc#roominfo_description" label="Description"><value>Chatroom that hosts the weekly support chat.</value></field><field var="muc#roominfo_subject" label="Subject"><value>Where hope springs eternal! +++ Openfire 4.0.3 is released +++ Smack 4.1.8 and 4.2.0-beta2 released</value></field><field var="muc#roominfo_occupants" label="Number of occupants"><value>5</value></field><field var="x-muc#roominfo_creationdate" label="Creation date"><value>2010-07-13T22:17:38.892Z</value></field></x></query><error code="503" type="cancel"><service-unavailable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/><text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">User session terminated</text></error></iq> 
      at org.xmpp.packet.IQ.createResultIQ(IQ.java:384) 
      at org.jivesoftware.openfire.muc.spi.LocalMUCUser.sendErrorPacket(LocalMUCUser.java:164) 
      at org.jivesoftware.openfire.muc.spi.LocalMUCUser.process(LocalMUCUser.java:390) 
      at org.jivesoftware.openfire.muc.spi.LocalMUCUser.process(LocalMUCUser.java:194) 
      at org.jivesoftware.openfire.muc.spi.MultiUserChatServiceImpl.processPacket(MultiUserChatServiceImpl.java:352) 
      at org.jivesoftware.openfire.component.InternalComponentManager$RoutableComponents.process(InternalComponentManager.java:606) 
      at org.jivesoftware.openfire.spi.RoutingTableImpl.routeToComponent(RoutingTableImpl.java:406) 
      at org.jivesoftware.openfire.spi.RoutingTableImpl.routePacket(RoutingTableImpl.java:248) 
      at org.jivesoftware.openfire.IQRouter.handle(IQRouter.java:323) 
      at org.jivesoftware.openfire.IQRouter.route(IQRouter.java:115) 
      at org.jivesoftware.openfire.spi.PacketRouterImpl.route(PacketRouterImpl.java:78) 
      at org.jivesoftware.openfire.net.SocketReader.processIQ(SocketReader.java:269) 
      at org.jivesoftware.openfire.net.ServerSocketReader.processIQ(ServerSocketReader.java:79) 
      at org.jivesoftware.openfire.net.SocketReader.process(SocketReader.java:238) 
      at org.jivesoftware.openfire.net.BlockingReadingMode.readStream(BlockingReadingMode.java:168) 
      at org.jivesoftware.openfire.net.BlockingReadingMode.run(BlockingReadingMode.java:76) 
      at org.jivesoftware.openfire.net.SocketReader.run(SocketReader.java:145)

        Attachments

          Activity

            People

            Assignee:
            guus Guus der Kinderen
            Reporter:
            guus Guus der Kinderen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: