Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Cache implementations should have consistent behavior regarding null keys

Description

It appears that various implementations of Cache have different behavior, regarding null keys (DefaultCache allows them, while the Hazelcast-backed cache does not).

Behavior should be consistent (and documented).

Environment

None
100% Done
Loading...

Activity

Daryl Herzmann 
December 12, 2016 at 3:17 PM

Setting this to a blocker as it is something that needs straightened out/resolved prior to release.

Tom Evans 
August 15, 2016 at 7:35 PM

Perhaps emitting a warning log message would be preferable to throwing an exception. Specifically it would be helpful to know which caches are using this currently undocumented "feature" and for what purpose.

In addition, the modified behavior should be configurable via system property (e.g. allowNullCacheKeys = true|false).

Guus der Kinderen 
August 12, 2016 at 7:14 PM

This fix introduced instability, as discussed in the original pull request: https://github.com/igniterealtime/Openfire/pull/609

I've created a PR to revert the original change here: https://github.com/igniterealtime/Openfire/pull/625

As far as I'm concerned, a change similar to this is still desirable. We should revisit the proposed solution.

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created June 28, 2016 at 2:17 PM
Updated December 20, 2016 at 4:25 PM
Resolved December 20, 2016 at 4:25 PM