Jive Software Open Source

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • XIFF
  • XIFF-3

Private messaging in conferencing

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.0 Beta 4, 3.0.0 Beta 1
  • Fix Version/s: 3.0.0
  • Component/s: Extensions
  • Labels:
    None

Description

This is based on a user's input from a while ago. I don't think I ever addressed the issue, but it involves a minor adjustment in the Room.as script. I haven't checked to see if his fix works or is optimal yet. Here's his e-mail:

--------------------------------------------------------------

So.. I was playing a bit with the Room.sendPrivateMessage() Method
when I realized that the privateMessageEvent was not returned correctly.

You couldnt trace it as ' type : privateMessage ' because it was
returned as ' type : incomingData '.
So I dig a little in the Room.as and correct it:

------------------------

Original:

case "message":
var msg:Message = eventObj.data;

// Check to see that the message is from this room
if( isFromThisRoom( msg.from ) && msg.type ==
Message.GROUPCHAT_TYPE ) {
// Check for a subject change
if( msg.subject != null ) {
var eventObj:Object = {target:this, type:"subjectChange", subject:msg.subject};
dispatchEvent( eventObj );
}
else {
var eventObj:Object = {target:this, type:"groupMessage", data:msg};
dispatchEvent( eventObj );
}
}

// It could be a private message via the conference
else if( msg.to == getFullRoomName() + "/" + nickname
&& msg.type == Message.CHAT_TYPE ) {
var eventObj:Object = {target:this, type:"privateMessage", data:msg};
dispatchEvent( eventObj );
}
break;

----------------------------------------

Corrected: (line 376) // Check to see that the PRIVATE message is from this room

case "message":
var msg:Message = eventObj.data;

// Check to see that the message is from this room
if( isFromThisRoom( msg.from ) && msg.type ==
Message.GROUPCHAT_TYPE ) {
// Check for a subject change
if( msg.subject != null ) {
var eventObj:Object = {target:this, type:"subjectChange", subject:msg.subject};
dispatchEvent( eventObj );
}
else {
var eventObj:Object = {target:this, type:"groupMessage", data:msg};
dispatchEvent( eventObj );
}
}
// Check to see that the PRIVATE message is from this room
else if( isFromThisRoom( msg.from ) && msg.type ==
Message.CHAT_TYPE ) {
// Check for a subject change
if( msg.subject != null ) {
var eventObj:Object = {target:this, type:"subjectChange", subject:msg.subject};
dispatchEvent( eventObj );
}
else {
var eventObj:Object = {target:this, type:"privateMessage", data:msg};
dispatchEvent( eventObj );
}
}
// It could be a private message via the conference
else if( msg.to == getFullRoomName() + "/" + nickname
&& msg.type == Message.CHAT_TYPE ) {
var eventObj:Object = {target:this, type:"privateMessage", data:msg};
dispatchEvent( eventObj );
}
break;

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
  • Source
  • Reviews
  • Builds
Hide
Permalink
Barry Tallis added a comment - 04/21/05 05:08 AM

Original code doesn't not match current Room.as code... Sean, can you take a look at this?

Show
Barry Tallis added a comment - 04/21/05 05:08 AM Original code doesn't not match current Room.as code... Sean, can you take a look at this?
Hide
Permalink
Sean Voisen added a comment - 12/17/06 04:42 AM

AS2 ISSUE: Reinvestigate for AS3

Show
Sean Voisen added a comment - 12/17/06 04:42 AM AS2 ISSUE: Reinvestigate for AS3
Hide
Permalink
Mark Walters added a comment - 06/18/10 04:35 PM

This issue has been fixed in the AS3 version of XIFF.

Show
Mark Walters added a comment - 06/18/10 04:35 PM This issue has been fixed in the AS3 version of XIFF.

People

  • Assignee:
    Mark Walters
    Reporter:
    Sean Voisen
Vote (1)
Watch (0)

Dates

  • Created:
    03/15/05 05:57 PM
    Updated:
    06/18/10 04:35 PM
    Resolved:
    06/18/10 04:35 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.