Spark

Spark is not reacting to outside keyboard events when setting the auto Away status

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0
  • Fix Version/s: 2.6.0 RC2
  • Component/s: None
  • Labels:
    None
  • Environment:

    Windows

Description

SPARK-163 has fixed the issue that Spark wasnt reacting to typing and setting Away. Now it reacts to typing in the chat window, but it doesnt react to the keyboard typing outside the Spark. E.g. one can be typing an email and Spark will go Away and wont react to this typing.

Attachments

  2. File
    outside_keyboard_events_win.diff
    12/05/10 10:53 AM
    4 kB
    wroot

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Neil McFarlane added a comment -

2.6.1 --> 2.7

Show
Neil McFarlane added a comment - 2.6.1 --> 2.7
Hide
Permalink
wroot added a comment - - edited

attaching patch proposed by hanguokai

Need to add these two jar(jna.jar & platform.jar ) in classpath.

If (isWindows) keyhook; else addGlobalListener for old behaviour

Show
wroot added a comment - - edited attaching patch proposed by hanguokai Need to add these two jar(jna.jar & platform.jar ) in classpath. If (isWindows) keyhook; else addGlobalListener for old behaviour
Hide
Permalink
Mike McMahon added a comment -

has this been tested and verified as working?

If so i will gladly push it through so it makes it in with the nightly build. Otherwise I will try to get on testing this ASAP.

Show
Mike McMahon added a comment - has this been tested and verified as working? If so i will gladly push it through so it makes it in with the nightly build. Otherwise I will try to get on testing this ASAP.
Hide
Permalink
wroot added a comment -

i havent tested this because of those additional jars that have to be added

Show
wroot added a comment - i havent tested this because of those additional jars that have to be added
Hide
Permalink
Mike McMahon added a comment -

I've been testing on my local system and it's working great; however, I am not sure what the protocol is for adding new libraries to spark.

If someone could please advise we should definitely get this committed to the source.

Show
Mike McMahon added a comment - I've been testing on my local system and it's working great; however, I am not sure what the protocol is for adding new libraries to spark. If someone could please advise we should definitely get this committed to the source.
Hide
Permalink
Mike McMahon added a comment - - edited

attached required jars for this patch. Must be added and linked to the projects source.

Show
Mike McMahon added a comment - - edited attached required jars for this patch. Must be added and linked to the projects source.
Hide
Permalink
Walter Ebeling added a comment -

Proposed patch requires relicencing of the idle plugin to LGPL due to the LGPL nature of jna.jar. These are incompatible with the Apache 2.0 licence of Spark.

Show
Walter Ebeling added a comment - Proposed patch requires relicencing of the idle plugin to LGPL due to the LGPL nature of jna.jar. These are incompatible with the Apache 2.0 licence of Spark.
Hide
Permalink
Walter Ebeling added a comment -

Please consider to license the user idle plugin as LGPL or GPL to make it compatible with the usage of jna and plattform.jar. We would bundle it in the nightly of Spark and note it in the licence statement about Spark.

Show
Walter Ebeling added a comment - Please consider to license the user idle plugin as LGPL or GPL to make it compatible with the usage of jna and plattform.jar. We would bundle it in the nightly of Spark and note it in the licence statement about Spark.
Hide
Permalink
Walter Ebeling added a comment -

We should re-licence the files needed to build the useridle plugin under LGPL. The patched useridle (as discussed in the forum) together with jna.jar and plattform.jna should go in the RC2.

Show
Walter Ebeling added a comment - We should re-licence the files needed to build the useridle plugin under LGPL. The patched useridle (as discussed in the forum) together with jna.jar and plattform.jna should go in the RC2.
Hide
Permalink
Walter Ebeling added a comment -

re license to LGPL for useridle.jar missing. Moving to 2.6.0

Show
Walter Ebeling added a comment - re license to LGPL for useridle.jar missing. Moving to 2.6.0
Hide
Permalink
Wolf P. added a comment -

relicensed and added

Show
Wolf P. added a comment - relicensed and added
Hide
Permalink
Walter Ebeling added a comment -

fixed in build 188

Show
Walter Ebeling added a comment - fixed in build 188

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.