Smack

Investigate SASL issue with jabberd2 servers

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.2.2
  • Component/s: None
  • Labels:
    None

Description

I have a little issue with this portion of code from SASLMechanism.java concerning the element 

public String toXML() {
    StringBuilder stanza = new StringBuilder();
    stanza.append("<response xmlns=\"urn:ietf:params:xml:ns:xmpp-sasl\">");
    if (authenticationText != null) {
        stanza.append(authenticationText);
    }
    else {
        // the else case should be removed
        stanza.append("=");
    }
    stanza.append("</response>");
    return stanza.toString();
}

This codes send a '=' instead of an empty response element. '=' is not a valid base64 string. This is generally the last response of a challenge so many servers don't check the additional data but some like jabberd2 check it and send an incorrect-encoding failure. I attach the corresponding exchange.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Johnston added a comment -

This issue seems to affect most Android xmpp clients connecting to jabberd2. BEEM have patched it http://www.beem-project.com/projects/beem/repository/revisions/786 , I can confirm it works (no built package available yet).

Show
Matt Johnston added a comment - This issue seems to affect most Android xmpp clients connecting to jabberd2. BEEM have patched it http://www.beem-project.com/projects/beem/repository/revisions/786 , I can confirm it works (no built package available yet).
Hide
Permalink
Walter Ebeling added a comment -

Looks like a patch that we want to include for RC2

Show
Walter Ebeling added a comment - Looks like a patch that we want to include for RC2
Hide
Permalink
Walter Ebeling added a comment -

Unfortunately there are report about this as being not fixed in 2.6.3.

http://community.igniterealtime.org/message/214456#214456

I am not sure how to deal with that.

Show
Walter Ebeling added a comment - Unfortunately there are report about this as being not fixed in 2.6.3. http://community.igniterealtime.org/message/214456#214456 I am not sure how to deal with that.
Hide
Permalink
Robin Collier added a comment -

Unfortunately, the fix was applied to trunk instead of the 3.2 branch so it did not get included in the 3.2.1 release. Luckily it is a simple fix, so it will be easy to apply to 3.2.2.

Show
Robin Collier added a comment - Unfortunately, the fix was applied to trunk instead of the 3.2 branch so it did not get included in the 3.2.1 release. Luckily it is a simple fix, so it will be easy to apply to 3.2.2.

People

  • Assignee:
    Robin Collier
    Reporter:
    wroot
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: