Jive Software Open Source

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Smack
  • SMACK-307

Improve Message Parser Robustness and Message Body I18N

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Ignite Forum URL:
    http://www.igniterealtime.org/community/thread/41420
  • Acceptance Test - Add?:
    No

Description

Smack should not close the connection if the message body contains additional tags. Although specification says that the body must not contain any tags it is user input and it should not be possible for a user with an errornous client to send messages that close the connection of other users.

Additionally for the parser to correctly set message bodies in different languages that may occur in a message packet the patch fixes the faulty handling of localized bodies.
A message tag may contain an xml:lang attribute which sets the default language of the message. This attribute is now not ignored anymore when correlating the message bodies to a language. Every message body now has a language associated (no null language for the default language of the message or application at the moment the body was set).

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    improve_message_parse_robustness.patch
    04/07/10 11:37 AM
    30 kB
    Henning Staib

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
  • Source
  • Reviews
  • Builds
Hide
Permalink
Henning Staib added a comment - 08/15/10 10:14 AM

fixed in revision 11824

Show
Henning Staib added a comment - 08/15/10 10:14 AM fixed in revision 11824

People

  • Assignee:
    Robin Collier
    Reporter:
    Henning Staib
Vote (1)
Watch (2)

Dates

  • Created:
    04/07/10 11:37 AM
    Updated:
    11/23/10 09:09 PM
    Resolved:
    11/23/10 09:09 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.