Smack

Extend the IQ API to create empty IQ results and IQ error response packets

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1.0
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

Since all IQ stanzas of type get and set should be replied with either an IQ result or error stanza, an easy to use API to create such responses should be introduced.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guenther Niess added a comment -

A small static function within the IQ class could do the job.

Show
Guenther Niess added a comment - A small static function within the IQ class could do the job.
Hide
Permalink
Henning Staib added a comment -

Nice patch but you forgot to set the id of the new iq the the id of the one given.

Show
Henning Staib added a comment - Nice patch but you forgot to set the id of the new iq the the id of the one given.
Hide
Permalink
Guenther Niess added a comment -

You're right, thanks! I've corrected the patch, added a unit test and committed it to revision 11669.

Show
Guenther Niess added a comment - You're right, thanks! I've corrected the patch, added a unit test and committed it to revision 11669.

People

  • Assignee:
    Guenther Niess
    Reporter:
    Guenther Niess
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: