Smack

Deadlock while getting Roster before it's initialized

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1.0
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None

Description

If XMPPConnection#getRoster is invoked after a login and the roster isn't received yet, smack will get stuck on waiting for roster initialization without success (it times out). Because the RosterPacketListener which handles the initialization depends also on the waiting XMPPConnection#getRoster method.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SMACK-115 RosterTest, FloodTest failures

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guenther Niess added a comment -

In the XMPPConnection class is commented:

If this is the first time the user has asked for the roster after calling login, we want to wait for the server to send back the user's roster. This behavior shields API users from having to worry about the fact that roster operations are asynchronous, although they'll still have to listen for changes to the roster.
Note: because of this waiting logic, internal Smack code should be wary about calling the getRoster method, and may need to access the roster object directly.

but the RosterEntry#getGroups method which is called within the RosterPacketListener:

// Find the list of groups that the user currently belongs to.
List<String> currentGroupNames = new ArrayList<String>();
for (RosterGroup rosterGroup : entry.getGroups()) {
  currentGroupNames.add(rosterGroup.getName());
}

depends on the XMPPConnection#getRoster method.

Show
Guenther Niess added a comment - In the XMPPConnection class is commented: If this is the first time the user has asked for the roster after calling login, we want to wait for the server to send back the user's roster. This behavior shields API users from having to worry about the fact that roster operations are asynchronous, although they'll still have to listen for changes to the roster. Note: because of this waiting logic, internal Smack code should be wary about calling the getRoster method, and may need to access the roster object directly. but the RosterEntry#getGroups method which is called within the RosterPacketListener : // Find the list of groups that the user currently belongs to. List< String > currentGroupNames = new ArrayList< String >(); for (RosterGroup rosterGroup : entry.getGroups()) { currentGroupNames.add(rosterGroup.getName()); } depends on the XMPPConnection#getRoster method.
Hide
Permalink
Guenther Niess added a comment -

Committed a patch to revision 11620.

Show
Guenther Niess added a comment - Committed a patch to revision 11620.

People

  • Assignee:
    Guenther Niess
    Reporter:
    Guenther Niess
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: