Smack

Deadlock in XMPPConnection while login and parsing stream features

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1.0
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

The Tigase XMPP server offers in-band registration in the authenticated XML stream. This causes a deadlock in the XMPPConnection by trying to get the AccountManager while it is blocked by the login method. The bug prevent to use Smack and Spark with an Tigase server.

Details see http://www.igniterealtime.org/community/message/191633#191633

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guenther Niess added a comment -

Thanks in advance for having a look at this issue.

Show
Guenther Niess added a comment - Thanks in advance for having a look at this issue.
Hide
Permalink
Guenther Niess added a comment -

After a second review and long testing I committed the patch to r11227.

Show
Guenther Niess added a comment - After a second review and long testing I committed the patch to r11227.
Hide
Permalink
Jason Eacott added a comment -

This problem has returned
I just checked out the latest trunk (in order to try the new pubsub stuff)
and this problem exists again. I can login against tigase with my older version, but not with the latest trunk.

Show
Jason Eacott added a comment - This problem has returned I just checked out the latest trunk (in order to try the new pubsub stuff) and this problem exists again. I can login against tigase with my older version, but not with the latest trunk.
Hide
Permalink
Jason Eacott added a comment -

Actually I take this back.
I've tracked the problem and discovered that it seems tigase never sends a 'session' stream feature, only register and bind. eg:

<stream:features><register xmlns="http://jabber.org/features/iq-register"/><bind xmlns="urn:ietf:params:xml:ns:xmpp-bind"/></stream:features>

If I force the client to ignore the fact it never saw this feature and assume it exists then everything works.

Show
Jason Eacott added a comment - Actually I take this back. I've tracked the problem and discovered that it seems tigase never sends a 'session' stream feature, only register and bind. eg: <stream:features><register xmlns="http://jabber.org/features/iq-register"/><bind xmlns="urn:ietf:params:xml:ns:xmpp-bind"/></stream:features> If I force the client to ignore the fact it never saw this feature and assume it exists then everything works.

People

  • Assignee:
    Guus der Kinderen
    Reporter:
    Guenther Niess
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: