Smack

Offer an alternative to loading the Roster on login

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.1.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

Currently, Smack requests the roster as part of the login() method. This often is convenient, but is annoying if a more light-weight connection is required.

We, for example, use Smack for automated tests which run frequently. Most of the tests have no need for the roster. Retrieving the roster for every login causes useless overhead for those tests.

An additional login() method that does not "pre-load" the roster would solve our issue. The roster should be loaded during the first call to getRoster() if it wasn't pre-loaded.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Diego H. Méndez added a comment -

I've got a patch to fix this but I don't have enough rights to attach it to this issue.

Show
Diego H. Méndez added a comment - I've got a patch to fix this but I don't have enough rights to attach it to this issue.
Hide
Permalink
Guus der Kinderen added a comment -

I'm attaching Diego's patch.

Show
Guus der Kinderen added a comment - I'm attaching Diego's patch.
Hide
Permalink
Guus der Kinderen added a comment -

Diego found a problem in the modification that we did. The Roster object should always be initialized, no matter if we want to pre-load the roster or not. This sets a listener, that we need to have regardless of the preload boolean.

Show
Guus der Kinderen added a comment - Diego found a problem in the modification that we did. The Roster object should always be initialized, no matter if we want to pre-load the roster or not. This sets a listener, that we need to have regardless of the preload boolean.
Hide
Permalink
Guus der Kinderen added a comment -

Diego provided an additional patch that should be applied to the source code to which the previous patch has already been applied.

Show
Guus der Kinderen added a comment - Diego provided an additional patch that should be applied to the source code to which the previous patch has already been applied.

People

  • Assignee:
    Gaston Dombiak
    Reporter:
    Guus der Kinderen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: