Smack

Packet with wrong date format makes Smack to disconnect

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 3.0.4
  • Fix Version/s: 3.2.0
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

reported at: http://www.igniterealtime.org/community/thread/32742
affects Spark (and other Smack based clients): http://www.igniterealtime.org/community/thread/33364

tested with Openfire and gtalk (so it shouldnt be affected only by Openfire bug)

faulty packet example:

<message to="victim@hisserver.fr/spark" type="chat" id="1345">
<body>plop</body>
<x xmlns="jabber:x:delay" stamp="200868T09:16:20" from="mylogin@monserver.fr"/>
<thread>9gOp44</thread>
</message>

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. SMACK-252 Soften Smack's response to certain kinds of well-formed, but otherwise defective XML packets

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. SPARK-1100 Spark disconnects when doing or receiving file transfer (Digsby, JBother)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
wroot added a comment -

This is a long standing and having "exploits" issue. Why this is not fixed yet?

Show
wroot added a comment - This is a long standing and having "exploits" issue. Why this is not fixed yet?
Hide
Permalink
Matt Tucker added a comment -

I'm taking this issue and will see if I can get it resolved next week.

Show
Matt Tucker added a comment - I'm taking this issue and will see if I can get it resolved next week.
Hide
Permalink
Imre Fazekas added a comment -

I'm using smack for RPC and I have the same issue occurring every few hours making me a lot of headaches

at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:260)
at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43)
at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:70)
Message:Connection closed on Errorlocalhost:5222@nform.eva.connexis.com/slinker
Parameter:stream:error (text)

Any idea for a workaround or a fix?
Thanks in advance!

Show
Imre Fazekas added a comment - I'm using smack for RPC and I have the same issue occurring every few hours making me a lot of headaches at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:260) at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43) at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:70) Message:Connection closed on Errorlocalhost:5222@nform.eva.connexis.com/slinker Parameter:stream:error (text) Any idea for a workaround or a fix? Thanks in advance!
Hide
Permalink
Imre Fazekas added a comment -

Dropping the package if it is found invalid? Rather than the connection ...

Show
Imre Fazekas added a comment - Dropping the package if it is found invalid? Rather than the connection ...
Hide
Permalink
Henning Staib added a comment -

The attached patch fixes the disconnect caused by the ParseException and tries to parse ambiguous dates.

Show
Henning Staib added a comment - The attached patch fixes the disconnect caused by the ParseException and tries to parse ambiguous dates.
Hide
Permalink
Imre Fazekas added a comment -

Thanks, you are great!

When could be this patch added to the SVN repo?

Show
Imre Fazekas added a comment - Thanks, you are great! When could be this patch added to the SVN repo?
Hide
Permalink
Imre Fazekas added a comment -

I got the same exception. The patch doesn't resolve the problem entirely:

stream:error (text)
at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:260)
at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43)
at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:70)
Message:Connection closed on Errorlocalhost:5222@nform.eva.connexis.com/slinker
Parameter:stream:error (text)

Show
Imre Fazekas added a comment - I got the same exception. The patch doesn't resolve the problem entirely: stream:error (text) at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:260) at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43) at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:70) Message:Connection closed on Errorlocalhost:5222@nform.eva.connexis.com/slinker Parameter:stream:error (text)
Hide
Permalink
Henning Staib added a comment -

Your stream error problem and the fixes of my patch are not connected.
The patch fixes parsing a <message> or <presence> tag containing a <delay> tag with an errornous date.

Your problem seems to be that one of the entities you are communicating with sends an error in the XML stream.
(<stream> ... <message>...</message> ... <error>text</error> ... </stream>). So you should check why this error is sent.

Show
Henning Staib added a comment - Your stream error problem and the fixes of my patch are not connected. The patch fixes parsing a <message> or <presence> tag containing a <delay> tag with an errornous date. Your problem seems to be that one of the entities you are communicating with sends an error in the XML stream. (<stream> ... <message>...</message> ... <error>text</error> ... </stream>). So you should check why this error is sent.
Hide
Permalink
Henning Staib added a comment -

moved the XEP_0082_UTC_FORMAT DateFormat from the core class Packet to the StringUtils class (as suggested by Guus).
Added synchronized methods to access the formatter and replaced all usage of the formatter with this methods.

Show
Henning Staib added a comment - moved the XEP_0082_UTC_FORMAT DateFormat from the core class Packet to the StringUtils class (as suggested by Guus). Added synchronized methods to access the formatter and replaced all usage of the formatter with this methods.
Hide
Permalink
Henning Staib added a comment -

fixed in revision 11823

Show
Henning Staib added a comment - fixed in revision 11823
Hide
Permalink
Marcelo Soares da Silva added a comment -

Hi

I had same problems. Working on it I found and fixed an error on:

src\java\org\jivesoftware\util\XMPPDateTimeFormat.java

changing:

ln 99: Matcher xep82WoMillisMatcher = xep80DateTimePattern.matcher(dateString);
ln 100: Matcher xep82Matcher = xep80DateTimeWoMillisPattern.matcher(dateString);

for

ln 99: Matcher xep82Matcher = xep80DateTimePattern.matcher(dateString);
ln100: Matcher xep82WoMillisMatcher = xep80DateTimeWoMillisPattern.matcher(dateString);

Best Regards

Marcelo

Show
Marcelo Soares da Silva added a comment - Hi I had same problems. Working on it I found and fixed an error on: src\java\org\jivesoftware\util\XMPPDateTimeFormat.java changing: ln 99: Matcher xep82WoMillisMatcher = xep80DateTimePattern.matcher(dateString); ln 100: Matcher xep82Matcher = xep80DateTimeWoMillisPattern.matcher(dateString); for ln 99: Matcher xep82Matcher = xep80DateTimePattern.matcher(dateString); ln100: Matcher xep82WoMillisMatcher = xep80DateTimeWoMillisPattern.matcher(dateString); Best Regards Marcelo
Hide
Permalink
Florian Schmaus added a comment -

@Marcelo Maybe you should mention that you where making these changes in the openfire source code. This is tracked as OF-646 and has been fixed in the trunk.

Show
Florian Schmaus added a comment - @Marcelo Maybe you should mention that you where making these changes in the openfire source code. This is tracked as OF-646 and has been fixed in the trunk.

People

  • Assignee:
    Robin Collier
    Reporter:
    wroot
Vote (8)
Watch (11)

Dates

  • Created:
    Updated:
    Resolved: