Jive Software Open Source

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Openfire
  • OF-78

Update Tinder to 1.2.1

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.6.4
  • Fix Version/s: 3.7.0 beta
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

Update the Tinder library to version 1.2

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    excludeXmlAPI.patch
    11/09/09 02:49 PM
    0.4 kB
    Guenther Niess

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. OF-133 add source of stringprep to ./build/lib/versions.txt

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
  • Source
  • Reviews
  • Builds
Hide
Permalink
Guus der Kinderen added a comment - 11/07/09 01:00 PM

Note that some stringprep-related packages have changed.

Show
Guus der Kinderen added a comment - 11/07/09 01:00 PM Note that some stringprep-related packages have changed.
Hide
Permalink
Guenther Niess added a comment - 11/09/09 01:23 PM

With the new tinder-with-dependencies.jar I get a conflict with the included org.w3c.dom.Element respectively org.w3c.dom.Node class it doesn't match with the JDK5 API. It doesn't include the org.w3c.dom.Element#getTextContent method wich is used in the org.jivesoftware.openfire.launcher.Launcher class. This has the effect that my Eclipse environment throws the error: "The method getTextContent() is undefined for type Element ". How can I correct this error?

Show
Guenther Niess added a comment - 11/09/09 01:23 PM With the new tinder-with-dependencies.jar I get a conflict with the included org.w3c.dom.Element respectively org.w3c.dom.Node class it doesn't match with the JDK5 API. It doesn't include the org.w3c.dom.Element#getTextContent method wich is used in the org.jivesoftware.openfire.launcher.Launcher class. This has the effect that my Eclipse environment throws the error: "The method getTextContent() is undefined for type Element ". How can I correct this error?
Hide
Permalink
Guus der Kinderen added a comment - 11/09/09 02:04 PM

Apparently Eclipse built a java-6 version of the library, even though the pom states that we're using 5. I've redone it, manually. Try now.

Show
Guus der Kinderen added a comment - 11/09/09 02:04 PM Apparently Eclipse built a java-6 version of the library, even though the pom states that we're using 5. I've redone it, manually. Try now.
Hide
Permalink
Guenther Niess added a comment - 11/09/09 02:49 PM

It didn't help. With the attached excludeXmlAPI patch the related classes will be excluded from the JAR. In my opinion all classes which are provided with the XML-APIs JAR are provided by the JDK5. But I think this should be reviewed.

Show
Guenther Niess added a comment - 11/09/09 02:49 PM It didn't help. With the attached excludeXmlAPI patch the related classes will be excluded from the JAR. In my opinion all classes which are provided with the XML-APIs JAR are provided by the JDK5. But I think this should be reviewed.
Hide
Permalink
Guenther Niess added a comment - 11/09/09 03:04 PM

On the dom4j dependencies it's noted that the xml-apis is only required to compile and run unit tests for the application. So maybe we create a tinder issue to remove this transitive dependency for the compile scope of tinder.

Show
Guenther Niess added a comment - 11/09/09 03:04 PM On the dom4j dependencies it's noted that the xml-apis is only required to compile and run unit tests for the application. So maybe we create a tinder issue to remove this transitive dependency for the compile scope of tinder.
Hide
Permalink
Guus der Kinderen added a comment - 11/16/09 09:45 PM

I'm puzzled: how do you get the original error? org.jivesoftware.openfire.launcher.Launcher uses the rt.jar in jre 1.5 when resolving the org.w3c.dom package in Eclipse.

Show
Guus der Kinderen added a comment - 11/16/09 09:45 PM I'm puzzled: how do you get the original error? org.jivesoftware.openfire.launcher.Launcher uses the rt.jar in jre 1.5 when resolving the org.w3c.dom package in Eclipse.
Hide
Permalink
Guus der Kinderen added a comment - 12/01/09 09:26 PM

I'm going to tackle this in another way: Prior to Tinder, whatever dependencies where needed were already in Openfire. I didn't remove any of those libraries, so they should still be there. I did however add more of the same, by packaging them in the Tinder-with-Dependencies jar. This might account for the problems that you're seeing. I will replace the -with-dependencies with a jar without them. Instead, I will add the dependencies separately. Dom4j is already in there, so I'll not add another one. This should avoid an additional xml-apis.jar in your eclipse. At the very least, it will restore the state of the project to what it was before Tinder was added.

Show
Guus der Kinderen added a comment - 12/01/09 09:26 PM I'm going to tackle this in another way: Prior to Tinder, whatever dependencies where needed were already in Openfire. I didn't remove any of those libraries, so they should still be there. I did however add more of the same, by packaging them in the Tinder-with-Dependencies jar. This might account for the problems that you're seeing. I will replace the -with-dependencies with a jar without them. Instead, I will add the dependencies separately. Dom4j is already in there, so I'll not add another one. This should avoid an additional xml-apis.jar in your eclipse. At the very least, it will restore the state of the project to what it was before Tinder was added.
Hide
Permalink
Guus der Kinderen added a comment - 12/01/09 10:01 PM

Done.

I have replaced the StringPrep jar with LibIDN. This is a dependency of Tinder and an updated variant of StringPrep. The libraries are interchangable, with the exception of package definitions.

Show
Guus der Kinderen added a comment - 12/01/09 10:01 PM Done. I have replaced the StringPrep jar with LibIDN. This is a dependency of Tinder and an updated variant of StringPrep. The libraries are interchangable, with the exception of package definitions.
Hide
Permalink
Guus der Kinderen added a comment - 01/02/10 02:52 PM

We should update to 1.2.1, because of TINDER-34

Show
Guus der Kinderen added a comment - 01/02/10 02:52 PM We should update to 1.2.1, because of TINDER-34
Hide
Permalink
Guus der Kinderen added a comment - 01/02/10 03:01 PM

Done (no-one notices that I didn't actually release 1.2.1 yet, right )

Show
Guus der Kinderen added a comment - 01/02/10 03:01 PM Done (no-one notices that I didn't actually release 1.2.1 yet, right )

People

  • Assignee:
    Guus der Kinderen
    Reporter:
    Guus der Kinderen
Vote (0)
Watch (1)

Dates

  • Created:
    11/07/09 12:59 PM
    Updated:
    02/14/10 10:22 AM
    Resolved:
    01/02/10 03:01 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.