The AuthorizationManager has a getInstance() method and private constructor, which makes it a singleton.
Unfortunately, it has only static data and methods so the creation of any instance is completely pointless. It is a utility class (i.e. static), and should not be singleton. The getInstance() method and instance member should be removed.
Environment
None
Activity
Tom Evans
April 25, 2014 at 11:23 PM
Removed getInstance(), instance variable, and constructor.
Tom Evans
April 25, 2014 at 7:56 PM
Agreed, and is a quick fix. I found no usages of the extraneous getInstance() method.
The AuthorizationManager has a getInstance() method and private constructor, which makes it a singleton.
Unfortunately, it has only static data and methods so the creation of any instance is completely pointless. It is a utility class (i.e. static), and should not be singleton. The getInstance() method and instance member should be removed.