Details
-
Type:
Improvement
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.6.4
-
Fix Version/s: 3.7.0 beta
-
Component/s: Admin Console
-
Labels:None
-
Acceptance Test - Add?:No
Description
http://www.igniterealtime.org/community/message/157461#157461
1. You have to enter full JIDs, it should default to your domain.
2. When you delete users from your server, it doesn't clean out the MUC affliations of those users.
3. It would be nice if it defaulted to 'Member' type for new additions, but that is a small nitpick. Or at least default to the last type just added on previous page submit. I find myself adding orders of magnitude more members than admins
Attachments
Activity
Regarding request #3, this would only be possible if the affliation was passed via the URL, since the action causes a page redirect. I assume the page redirect is necessary, so maybe #3 can be dropped from my RFE for now
I've wrote two patches to fix the bug. I would prefer to remove the possibility to add an JID by adding only the username. See also the bug report on the forum, thanks Brinley
Here is a simple patch for muc-room-affiliations.jsp not to fail if only a username is entered (fixes #1).
Index: muc-room-affiliations.jsp
===================================================================
— muc-room-affiliations.jsp (revision 10169)
+++ muc-room-affiliations.jsp (working copy)
@@ -53,10 +53,15 @@
// Handle an add
if (add) {
// do validation
+ if (userJID == null) { errors.put("userJID","userJID"); }
+ // No @ was found so assume this is a JID of a local user
+ if (userJID.indexOf('@') == -1) { + userJID = webManager.getXMPPServer().createJID(userJID, null).toBareJID(); + }
+
if (errors.size() == 0) {
try {
// Escape username
- if (userJID == null || userJID.indexOf('@') == -1) {
+ if (userJID == null) {
errors.put("userJID","userJID");
}
+ // No @ was found so assume this is a JID of a local user + if (userJID.indexOf('@') == -1) { + userJID = webManager.getXMPPServer().createJID(userJID, null).toBareJID(); + } + if (errors.size() == 0) { try { // Escape username