Openfire should send room's subject regardless any user side history limits
Description
Environment
Attachments
is related to
Activity
Guenther Niess November 6, 2009 at 5:56 PM
Committed a patch which checks if the last subject change is included in the limited room history and adds them if necessary.
Guenther Niess October 21, 2009 at 4:44 PM
Ben, your patch sends the room subject twice in most of the use cases. I think the last subject is handled correctly if no user history limit is provided or if it's in the range. Your added subject message don't provide the users JID which has changed the last subject. Openfire should be compatible with JDK 1.5, but the used String#isEmpty() method is only available in JDK 1.6.
Guenther Niess October 21, 2009 at 10:11 AM
Peter Saint-Andre has clarified:
> Our problem is, if a client requests a limited history how should this limit affect the last subject?
The room should always send you the subject. The subject is not part of this history, it is more like a defining part of the room (or at least the room's current context).
Maxim Britov October 18, 2009 at 7:54 PM
"In addition, the room SHOULD include the last subject change in the discussion history sent when a new occupant joins the room."
http://xmpp.org/extensions/xep-0045.html#subject-mod
wroot October 18, 2009 at 4:23 PM
I agree with Guenther on that. Closing the ticket.
reported at: http://www.igniterealtime.org/community/message/195267
Though it is not described in XEP-0045, but some users assume, that room's subject should be always sent regardless the history limit user has set. Currently Openfire is sending room's subject as a regular message (after topic has been changed), so if there were a lot of messages after the topic change and user has requested to send only a few stanzas (or chars), he won't get that topic change message and so his room will stay without a topic at all.