Presence issues with LDAP and shared groups

Check line 128 of Roster.java. The call to hasMutualVisibility is using "userGroups" instead of "sharedGroups". Not sure if this is the root problem but changing to "sharedGroups" does make everything work correctly.

Temporary issue is in place for the beta 3 release. We need to make the code more efficient, so leaving this issue open.

Same problem on version Openfire 3.4.5. The contacts status only is updated when the client login to the server, later the changes in the status of the contacts isn't updated.

Same problem here with Openfire 3.5.1. The contact status is not updated when using groups from LDAP. Changing to DefaultGroupProvider and creating groups on openfire resolves the problem but I think it has to be resolved anyway.

Same problem, and the Roster.java "patch" works...

diff -u -r openfire_src_p/src/java/org/jivesoftware/openfire/roster/Roster.java openfire_src/src/java/org/jivesoftware/openfire/roster/Roster.java
— openfire_src_p/src/java/org/jivesoftware/openfire/roster/Roster.java 2008-10-01 12:27:38.000000000 +0200
+++ openfire_src/src/java/org/jivesoftware/openfire/roster/Roster.java 2008-08-29 06:13:21.000000000 +0200
@@ -141,7 +141,7 @@
}
// Set subscription type to BOTH if the roster user belongs to a shared group
// that is mutually visible with a shared group of the new roster item

• if (rosterManager.hasMutualVisibility(username, sharedGroups, jid, itemGroups)) {
  + if (rosterManager.hasMutualVisibility(username, userGroups, jid, itemGroups)) { item.setSubStatus(RosterItem.SUB_BOTH); }
  else {

This really really should be applied ! Please :>

I'll reopen this and put it against 3.6.1 for consideration.

Hey Stefan,

Could you send me a diff with your patch? The patch you pasted in Jira is not very clear to me. It seems that you replaced 'sharedGroups' with 'userGroups' in the line 141 that is probably 146 in the current code in trunk. The problem is that the code in trunk is already using the 'userGroups' variable. IOW, I don't know which was your fix.

Thanks,

– Gato

Based on the first comment from George: 'The call to hasMutualVisibility is using "userGroups" instead of "sharedGroups".' and the fact that Stefan's first source directory in the diff is "openfire_src_p(atched?)" versus "openfire_src", I'm guessing Stefan accidentally reversed his patch.

Any chance of seeing this fix in 3.6.3?

Just to add that this would be a very worthwhile fix for us as well for our deployment.

Here's a corrected patch that works for us (Openfire 3.6.3):

diff -up openfire_src/src_orig/java/org/jivesoftware/openfire/roster/Roster.java openfire_src/src/java/org/jivesoftware/openfire/roster/Roster.java
— openfire_src/src_orig/java/org/jivesoftware/openfire/roster/Roster.java 2009-03-11 08:52:59.000000000 +0200
+++ openfire_src/src/java/org/jivesoftware/openfire/roster/Roster.java 2009-03-11 08:52:50.000000000 +0200
@@ -143,7 +143,7 @@ public class Roster implements Cacheable
}
// Set subscription type to BOTH if the roster user belongs to a shared group
// that is mutually visible with a shared group of the new roster item

• if (rosterManager.hasMutualVisibility(username, userGroups, jid, itemGroups)) {
  + if (rosterManager.hasMutualVisibility(username, sharedGroups, jid, itemGroups)) { item.setSubStatus(RosterItem.SUB_BOTH); }
  else {

Can you post the compiled Roster.class with this fix in it?

Committed 1 line patch with revision 11087. Should appear in next release. thanks

reopening to fix versions, my bad