LocalOutgoingServerSession logs connection failures over verbosely

Description

When LocalOutgoingServerSession.createOutgoingSession encounters an error in connecting it logs a verbose error to the logs including a stack trace to the exception site. Seeing most of these error types are expected (such as host not found) and the stack trace is not especially useful in solving these problems this is needlessly verbose and makes it harder for a server operator to find real problems. This is componeded by openfire then traversing the domain to try connect.

Suggestion: expected errors like HostNotFound and Connection timeout errors should just log the information, other exceptions should continue to log the full error.

Environment

None

Attachments

3

Activity

Show:

Tom Evans May 6, 2014 at 6:30 PM

Updated to suppress stack traces only, without changing S2S exception handling logic.

Daryl Herzmann May 6, 2014 at 6:30 PM

Running igniterealtime with updated patch, TLS s2s sessions looks good now. I think we can close this

Tom Evans May 6, 2014 at 5:00 PM

Reverted patch because it broke the TLS handling logic for S2S connections.

Tom Evans April 25, 2014 at 11:23 PM

Modified patch for more recent changes to LocalOutgoingServerSession.

Tom Evans April 25, 2014 at 10:28 PM

I'm OK with this; will merge and validate.

Fixed

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

Created June 9, 2009 at 8:01 PM
Updated May 6, 2014 at 6:30 PM
Resolved May 6, 2014 at 6:30 PM