[#OF-191] store offline messages with empty body for pubsub - Jive Software Open Source

Details

Type: Bug
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: 3.6.4
Fix Version/s: 3.7.1
Component/s: PubSub

Acceptance Test - Add?:
No
Acceptance Test - Entry:

Hide

create a pubsub node, subscribe two users.
publish something while one is offline and the other is online
login the offline user, he should get the published content.
See also http://www.igniterealtime.org/community/thread/36322

Show
create a pubsub node, subscribe two users. publish something while one is offline and the other is online login the offline user, he should get the published content. See also http://www.igniterealtime.org/community/thread/36322

Description:

see http://www.igniterealtime.org/community/thread/36322
OfflineMessageStore.java ignores "empty-bodied" messages (line 113, addMessage() method. Pubsub messages are dropped therefore.

Activity

Ascending order - Click to sort in descending order

Daryl Herzmann made changes - 01/11/10 01:35 PM

Field	Original Value	New Value
Affects Version/s	3.6.2 [ 10832 ]
Component/s	Core [ 10002 ]
Component/s		PubSub [ 10237 ]
Affects Version/s		3.6.4 [ 10855 ]
Key	JM-1508	OF-191
Project	Openfire (ARCHIVED) [ 10010 ]	Openfire [ 10140 ]

Daryl Herzmann made changes - 01/11/10 01:35 PM

Fix Version/s

3.6.6 [ 10861 ]

Daryl Herzmann made changes - 01/31/10 08:35 PM

Fix Version/s	3.6.6 [ 10861 ]
Fix Version/s		3.7.1 [ 10855 ]

Daryl Herzmann made changes - 02/01/10 01:27 AM

Affects Version/s		3.6.4 [ 10870 ]
Affects Version/s	3.7.1 [ 10855 ]

Hide

Permalink

Rob Fuller added a comment - 03/15/10 02:37 PM

This fix seems to work:

if (message.getBody() == null || message.getBody().length() == 0) {
// ignore empty bodied message (typically chat-state notifications).
// but not pubsub messages
if(message.getChildElement("event", "http://jabber.org/protocol/pubsub#event") == null){ return; }
}

Show

Rob Fuller added a comment - 03/15/10 02:37 PM This fix seems to work: if (message.getBody() == null || message.getBody().length() == 0) { // ignore empty bodied message (typically chat-state notifications). // but not pubsub messages if(message.getChildElement("event", "http://jabber.org/protocol/pubsub#event") == null){ return; } }

People

Assignee:

Gaston Dombiak

Reporter:

LG
Votes:

6

Watchers:

5

Dates

Created:

12/15/08 09:19 PM

Updated:

03/15/10 02:37 PM

Openfire

store offline messages with empty body for pubsub

Details

Activity

People

Dates