Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-1565

Roar plugin shouldn't show many popups when joining a chat room with old history

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.6.3, 2.7.0, 2.7.2, 2.8.0
    • Fix Version/s: None
    • Component/s: Group Chat

      Description

      Next patch is for Roar plugin to avoid showing many popups when you join old groupchat room (groupchat with already written messages). I am not sure if this patch is correct because i commented many lines in original source code and made old groupchat check much more simpler. So anyone experienced should check these changes, but for me it works fine.

      RoarMessageListener.patch

      \src\plugins\roar\src\java\org\jivesoftware\spark\roar
      changed Roar listener mechanic how to detect old groupchats

      2015.10.13 update:
      This is still an issue and it is easier to reproduce with a large number of rooms and also with auto-join (10 rooms with 5-10 messages each). Also on some test machines a few first rooms are opened with a red tab title and a number of unread messages (though it only has an old history). This seems like another race condition when some code fires up faster than the GUI one or Roar's and Spark thinks that it receives new messages.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                wroot wroot
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: