Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-1098

Investigate two functions in ContactItem.java which can cause issues

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Incomplete
    • Affects Version/s: 2.5.8, 2.6.0
    • Fix Version/s: 2.7.0
    • Component/s: General
    • Labels:
      None

      Description

      reported at: http://www.igniterealtime.org/community/message/196070

      On a system I unfortunately do not currently have access to Spark would not start without some changes to src/java/org/jivesoftware/spark/ui/ContactItem.java. This function checks a length against displayName.length(), but then uses StringUtils.unescape on displayName before using that length with substring(). unescape can make the string shorter, so that substring call can fail. I'm not sure why it did that consistently for me on only one system, though, and I can't currently tell you exactly what the failure mode was, but I do recall it made spark unusable (either no contacts window at all or an empty one).

      Also, the getMainWindowHeight() call in the same function should almost certainly be getMainWindowWidth().

        Attachments

          Activity

            People

            Assignee:
            wroot wroot
            Reporter:
            wroot wroot
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: