Uploaded image for project: 'Smack'
  1. Smack
  2. SMACK-839

Provider.parse() should not throw a generic Exception, but instead IOException and XmlPullParserException

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.4.0
    • Component/s: Core
    • Expected Effort:
      Medium

      Description

      Throwing Exception is usually not a good idea, since there a plenty of Exceptions that should not be catched by Smack.

      Instead, parse() should probably throw

      • ┬áIOException
      • XmlPullParserException
      • InvalidXmppXmlException (for example for XMPP/XEP schema violations)

      Ultimately this should also result in a different 'throws' signature of AbstractXMPPConnection.parseAndProcessStanza(), it should no longer throw Exception, but the exceptions parse() throws.

        Attachments

          Activity

            People

            • Assignee:
              flow Florian Schmaus
              Reporter:
              flow Florian Schmaus
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: