Uploaded image for project: 'Smack'
  1. Smack
  2. SMACK-629

Rework how Smack handles anonymous connections

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.6
    • Fix Version/s: 4.2.0
    • Component/s: Core
    • Labels:
    • Expected Effort:
      Medium

      Description

      Smack currently has two methods for login:

      • loginNonAnonymously
      • loginAnonymously

      this is causing some code duplication. Instead a single method should be used that handles the case when Smack should connect anonymously, i.e. using SASL ANONYMOUS.

      Sketch of the changes:

      • Introduce authenticateAnonymous() configuration builder method
      • Ensure that callback handler, username and password are not set if authenticate anonymous is set (the other way is not possible, since username could be provided by other means e.g. SASL EXTERNAL).
      • If authenticateAnonymous use only SASL ANONYMOUS mech
      • If !authenticateAnonymous ignore SASL ANONYMOUS mech

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              flow Florian Schmaus
              Reporter:
              flow Florian Schmaus
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: