Uploaded image for project: 'Smack'
  1. Smack
  2. SMACK-628

Rework Roster handling with anonymous connections

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.6
    • Fix Version/s: 4.2.0
    • Component/s: Core
    • Labels:
    • Expected Effort:
      Medium

      Description

      Smack currently prevents the retrieving of a user if it thinks that the connection is anonymous. This behaviour should be changed because it's not specified that anonymous XMPP connection MUST NOT have an roster. It's implementation specific. Instead, if an implementation disallows anonymous connections rosters, it will return an IQ error for roster operations.

      tl;dr: Remove all

      if (connection.isAnonymous())

      { throw new IllegalStateException() }

      code parts from Roster (and the relevant parts from AbstractXMPPConnection).

      See also http://xmpp.org/extensions/xep-0175.html#recommendations
      "The server MAY allow the client to establish relationships with local services and users; such relationships might include presence subscriptions and roster additions"

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              flow Florian Schmaus
              Reporter:
              flow Florian Schmaus
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: