Uploaded image for project: 'Smack'
  1. Smack
  2. SMACK-303

integrate of the extracted Socks5 bytestream API in file transfer API

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.2.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      Integration of the extracted Socks5 bytestream API in file transfer API

      • adds methods to Socks5ByteStreamManager to ignore a specific Socks5 bytestream request (to not notify about an incoming request if the request is expected as a reply to the file transfer request)
      • adds test for ignoring Socks5 bytestream requests

      FileTransferNegotiator:

      • now uses namespace constants from Socks5ByteStreamManager and IBBTransferNegotiator (were doubled in old implementation)
      • prevent multiple adding of features to ServiceDiscoveryManager
      • replaced usage of obsolete Socks5TransferNegotiatorManager with Socks5TransferNegotiator

      FileTransferNegotiatorManager:

      • removed unused interface

      Socks5TransferNegotiator:

      • rewrite to use extracted Socks5 bytestream API

      Socks5TransferNegotiatorManager:

      • obsolete because of extracted Socks5 bytestream API

      StreamNegotiator:

      • extended signatures of blocking methods to throw InterruptedException if interrupted while waiting for IO operations

      Tests:

      • SmackTestCase that use a real XMPP server establishing Socks5 bytestreams
      • tests will fail if XMPP server doesn't support Socks5 bytestreams or bidirectional streams

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rcollier Robin Collier
              Reporter:
              serevaris Henning Staib
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: