JID#toString() doesn't handle null-values well

Modified unit tests and fixed the erroneous code.

This issue is also happening in toBareJID() - sorry for posting here, but I don't seem to have Create permissions in Jira to create a new issue.

This issue kills disco requests of certain types of plugins (asterisk-im, for example, winds up presenting itself with null@phone.server instead of phone.server. This causes all sorts of mayhem when the client attempts to use that JID for further requests.

public String toBareJID() {
final StringBuilder sb = new StringBuilder();
if (this.node != null) { sb.append(this.node); sb.append('@'); }
sb.append(this.domain);
return sb.toString();
}

Bloody... you're right! I'll fix this in a bit. Thanks for reporting!

I've committed a fix for the bare JID problem.

heh - thanks for the quick turnaround. It took us many, many hours to track down the root cause on this (it's hard to get a full build of openfire up and running in Eclipse - I guess some day they'll Mavenize it, eh?)

I'm sorry to hear that. Issues like these shouldn't be in anything that is released, not even betas. I'm updating the tinder.jar in Openfire as-we-type. You should be able to use Openfire nightlies (did you find our Bamboo server at http://bamboo.igniterealtime.org ) starting tomorrow.

Thanks for the bamboo link - I had not seen that. I do a ton of open source work, so I'm generally quite comfortable with checking out code and working with it - OF is just a really big project, and it takes a lot of effort to get it set up in a debugging environment. No worries - I'm delighted to have it working.