BUZZ highlight chat tab

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.5.0 Beta 4
  • Fix Version/s: 2.6.0
  • Component/s: General
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

Having many Chat tabs open, when you receive a BUZZ it shakes but the associated tab does highlight.

How to reproduce it:
. User A chats with user B and C.
. User A is looking the tab B.
. User C sends A a BUZZ.
Result: User A shakes but do not highlight tab C.

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. SPARK-533 Buzz feature improvements

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Will (cstux) added a comment -

— ../../SubVersion/spark/src/java/org/jivesoftware/sparkimpl/plugin/alerts/BuzzPlugin.java 2008-04-23 09:32:38.000000000 +0200
+++ src/java/org/jivesoftware/sparkimpl/plugin/alerts/BuzzPlugin.java 2008-05-05 13:19:34.000000000 +0200
@@ -119,6 +119,7 @@
ChatFrame chatFrame = SparkManager.getChatManager().getChatContainer().getChatFrame();
if (chatFrame != null && chatFrame.isVisible()) { chatFrame.buzz(); + SparkManager.getChatManager().getChatContainer().activateChatRoom(room); }

// Insert offline message

Show
Michael Will (cstux) added a comment - — ../../SubVersion/spark/src/java/org/jivesoftware/sparkimpl/plugin/alerts/BuzzPlugin.java 2008-04-23 09:32:38.000000000 +0200 +++ src/java/org/jivesoftware/sparkimpl/plugin/alerts/BuzzPlugin.java 2008-05-05 13:19:34.000000000 +0200 @@ -119,6 +119,7 @@ ChatFrame chatFrame = SparkManager.getChatManager().getChatContainer().getChatFrame(); if (chatFrame != null && chatFrame.isVisible()) { chatFrame.buzz(); + SparkManager.getChatManager().getChatContainer().activateChatRoom(room); } // Insert offline message
Hide
Permalink
wroot added a comment -

Michael, if this is a patch, i believe you should sign a contributor agreement. Though, maybe such small change could be incorporated without that.

Show
wroot added a comment - Michael, if this is a patch, i believe you should sign a contributor agreement. Though, maybe such small change could be incorporated without that.
Hide
Permalink
Michael Will (cstux) added a comment -

Yes, this is a patch,
How can i do that?

Show
Michael Will (cstux) added a comment - Yes, this is a patch, How can i do that?
Hide
Permalink
wroot added a comment -

http://www.igniterealtime.org/community/docs/DOC-1495 or you can try contacting Daniel at daniel.henninger@jivesoftware.com

Show
wroot added a comment - http://www.igniterealtime.org/community/docs/DOC-1495 or you can try contacting Daniel at daniel.henninger@jivesoftware.com
Hide
Permalink
Daniel Henninger added a comment -

Fixed with patch from cstux.

Show
Daniel Henninger added a comment - Fixed with patch from cstux.

People

  • Assignee:
    Daniel Henninger
    Reporter:
    Francisco Vives
Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: