Spark

Spark doesn't list rooms when subject has a null value

Details

Description

When Openfire sends am xml with null value of room's subject, such room is not listed in the room browser. Probably it should still show such room (other clients do) and show n/a or null instead of the subject.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. OF-440 Typo in MultiUserChatServiceImpl with forms

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Bug - A problem which impairs or prevents the functions of the product. OF-493 Openfire sends wrong xml when a room has no subject set

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SMACK-362 smack throw NoSuchElementException if the muc#roominfo_subject has no values

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Walter Ebeling added a comment -

Please review and fix.

Show
Walter Ebeling added a comment - Please review and fix.
Hide
Permalink
Tim Jentz added a comment - - edited

I reviewed this issue and it seems that its an error related to smack.
If the subject is for that room is null, there will be no value element in the muc#roominfo.
RoomInfo.java in smack will only check if the subject is null, but not if the subject entry has
any values. In this specific case, this will leed to an NoSuchElementException exception.

I will provide a patch for that issue.

edit
Its an NoSuchElementException and no nullpointer exception

Show
Tim Jentz added a comment - - edited I reviewed this issue and it seems that its an error related to smack. If the subject is for that room is null, there will be no value element in the muc#roominfo. RoomInfo.java in smack will only check if the subject is null, but not if the subject entry has any values. In this specific case, this will leed to an NoSuchElementException exception. I will provide a patch for that issue. edit Its an NoSuchElementException and no nullpointer exception
Hide
Permalink
Walter Ebeling added a comment -

Waiting for Smack to integrate fix for Smack 362

Show
Walter Ebeling added a comment - Waiting for Smack to integrate fix for Smack 362
Hide
Permalink
Tim Jentz added a comment -

smack patch is now integrated in the smack release, so this issue is fixed.

Show
Tim Jentz added a comment - smack patch is now integrated in the smack release, so this issue is fixed.
Hide
Permalink
Walter Ebeling added a comment -

Mass closing of resolved issues

Show
Walter Ebeling added a comment - Mass closing of resolved issues

People

  • Assignee:
    Tim Jentz
    Reporter:
    wroot
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: