Spark
  1. Spark
  2. SPARK-1450

When network connection is lost, chat window cannot be closed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When network connection is lost and have a chat window opened, when closing, sometimes, the following exception is seen:

      stream:error (system-shutdown)
      at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:260)
      at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:43)
      at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:70)
      Exception in thread "AWT-EventQueue-1" java.lang.IllegalStateException: Not connected to server.
      at org.jivesoftware.smack.XMPPConnection.sendPacket(XMPPConnection.java:445)
      at org.jivesoftware.smackx.MessageEventManager.sendCancelledNotification(MessageEventManager.java:297)
      at org.jivesoftware.spark.ui.rooms.ChatRoomImpl.closeChatRoom(ChatRoomImpl.java:221)
      at org.jivesoftware.spark.ui.ChatContainer.cleanupChatRoom(ChatContainer.java:532)
      at org.jivesoftware.spark.ui.ChatContainer.access$000(ChatContainer.java:89)
      at org.jivesoftware.spark.ui.ChatContainer$1.tabRemoved(ChatContainer.java:121)
      at org.jivesoftware.spark.component.tabbedPane.SparkTabbedPane.fireTabRemoved(SparkTabbedPane.java:350)
      at org.jivesoftware.spark.component.tabbedPane.SparkTabbedPane.close(SparkTabbedPane.java:375)
      at org.jivesoftware.spark.ui.ChatContainer.closeTab(ChatContainer.java:798)
      at org.jivesoftware.spark.ui.ChatContainer.closeAllChatRooms(ChatContainer.java:565)
      at org.jivesoftware.spark.ui.ChatContainer$17.windowClosing(ChatContainer.java:125

      As a result, the chat window gets frozen and cannot be closed

        Activity

        Hide
        Mircea Carasel added a comment -

        commited

        r12868 = 03d331e9727e688de22f5d6d56f4b3547577e7a2

        -try/catch around SparkManager.getMessageEventManager().sendCancelledNotification(getParticipantJID(), threadID); to make sure that UI does not get blocked

        Show
        Mircea Carasel added a comment - commited r12868 = 03d331e9727e688de22f5d6d56f4b3547577e7a2 -try/catch around SparkManager.getMessageEventManager().sendCancelledNotification(getParticipantJID(), threadID); to make sure that UI does not get blocked
        Hide
        Walter Ebeling added a comment -

        Mass closing of resolved issues

        Show
        Walter Ebeling added a comment - Mass closing of resolved issues

          People

          • Assignee:
            Unassigned
            Reporter:
            Mircea Carasel
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: