Spark

Selecting 'Start a chat' in a group chat room opens an incomplete chat window

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

While in a group chat you can right click a participant and select 'Start a chat'. A chat window opens as shown in the attached screenshot. The header is missing to know who I am chatting with. Also, all the buttons are missing

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mircea Carasel added a comment -

commited

r12852 = 4a8a48aa780c47d01ef72af4b0dba34e27118d33

-create the chat room given the real bare jid address of the user
-if the user with which the chat is opened do not appear in the list, a green + button is added to the header

Show
Mircea Carasel added a comment - commited r12852 = 4a8a48aa780c47d01ef72af4b0dba34e27118d33 -create the chat room given the real bare jid address of the user -if the user with which the chat is opened do not appear in the list, a green + button is added to the header
Hide
Permalink
Mircea Carasel added a comment -

commiter

r12853 = 5d1058faeae42054f199156953da7af44a4c402a

-fix you cannot chat with yourself

Show
Mircea Carasel added a comment - commiter r12853 = 5d1058faeae42054f199156953da7af44a4c402a -fix you cannot chat with yourself
Hide
Permalink
wroot added a comment -

Are you sure this isn't going against XEPs? I see that other clients behave the same as Spark did. They are not switching to the real JID of the user but rather start chat with a nickname provided in the chat room. And this change results in another issue. If you can't get real JID (room configured this way), then you can't start a private chat with anyone in that room, nothing happens.

Show
wroot added a comment - Are you sure this isn't going against XEPs? I see that other clients behave the same as Spark did. They are not switching to the real JID of the user but rather start chat with a nickname provided in the chat room. And this change results in another issue. If you can't get real JID (room configured this way), then you can't start a private chat with anyone in that room, nothing happens.
Hide
Permalink
Mircea Carasel added a comment -

I tried with pidgin Pidgin 2.7.5-2 and when you open a chat from group-chat room, it switches you to the real JID of the user.

I think we can keep the current mechanism for users for which we can get real JID, and if we cannot get real JID of the user, I can put back the previous functionality - what do you think?

Show
Mircea Carasel added a comment - I tried with pidgin Pidgin 2.7.5-2 and when you open a chat from group-chat room, it switches you to the real JID of the user. I think we can keep the current mechanism for users for which we can get real JID, and if we cannot get real JID of the user, I can put back the previous functionality - what do you think?
Hide
Permalink
Mircea Carasel added a comment -

I noticed that groupChat.getMultiUserChat().getOccupant(groupJID).getJid() returns null, when xmpp server goes down and then back again, so I reverted my commits

Revert "SPARK-1445 - you cannot chat with yourself - fix"
Revert "SPARK-1445: Selecting 'Start a chat' in a group chat room opens an incomplete chat window"

Show
Mircea Carasel added a comment - I noticed that groupChat.getMultiUserChat().getOccupant(groupJID).getJid() returns null, when xmpp server goes down and then back again, so I reverted my commits Revert " SPARK-1445 - you cannot chat with yourself - fix" Revert " SPARK-1445 : Selecting 'Start a chat' in a group chat room opens an incomplete chat window"
Hide
Permalink
wroot added a comment -

Sorry for not replying for long (didnt get a notification). What do XEPs say about this? If it is by XEP, then i have no objection for it to start a chat with real JID. I think someone has once requested this even.

Show
wroot added a comment - Sorry for not replying for long (didnt get a notification). What do XEPs say about this? If it is by XEP, then i have no objection for it to start a chat with real JID. I think someone has once requested this even.
Hide
Permalink
Mircea Carasel added a comment -

I think you are right, XEP-0045 indicates to use the room occupant JID instead of the real JID when sending a message:

http://xmpp.org/extensions/xep-0045.html:

7.8 Sending a Private Message

Since each occupant has a unique room JID, an occupant MAY send a "private message" to a selected occupant via the service by sending a message to the occupant's room JID. The message type SHOULD be "chat" and MUST NOT be "groupchat", but MAY be left unspecified (i.e., a normal message). This privilege SHOULD be allowed to any occupant (even a visitor in a moderated room).

Example 57. Occupant Sends Private Message

<message
from='wiccarocks@shakespeare.lit/laptop'
to='darkcave@chat.shakespeare.lit/firstwitch'
type='chat'>
<body>I'll give thee a wind.</body>
</message>

Also, SMACK documentation says the same:

http://www.igniterealtime.org/builds/smack/docs/latest/documentation/extensions/muc.html#privchat
// Start a private chat with another participant
Chat chat = muc2.createPrivateChat("myroom@conference.jabber.org/johndoe");
chat.sendMessage("Hello there");

Show
Mircea Carasel added a comment - I think you are right, XEP-0045 indicates to use the room occupant JID instead of the real JID when sending a message: http://xmpp.org/extensions/xep-0045.html: 7.8 Sending a Private Message Since each occupant has a unique room JID, an occupant MAY send a "private message" to a selected occupant via the service by sending a message to the occupant's room JID. The message type SHOULD be "chat" and MUST NOT be "groupchat", but MAY be left unspecified (i.e., a normal message). This privilege SHOULD be allowed to any occupant (even a visitor in a moderated room). Example 57. Occupant Sends Private Message <message from='wiccarocks@shakespeare.lit/laptop' to='darkcave@chat.shakespeare.lit/firstwitch' type='chat'> <body>I'll give thee a wind.</body> </message> Also, SMACK documentation says the same: http://www.igniterealtime.org/builds/smack/docs/latest/documentation/extensions/muc.html#privchat // Start a private chat with another participant Chat chat = muc2.createPrivateChat("myroom@conference.jabber.org/johndoe"); chat.sendMessage("Hello there");
Hide
Permalink
wroot added a comment -

So, should we mark this as Won't fix?

Show
wroot added a comment - So, should we mark this as Won't fix?
Hide
Permalink
Mircea Carasel added a comment -

Yes, I think so...

Show
Mircea Carasel added a comment - Yes, I think so...

People

  • Assignee:
    Mircea Carasel
    Reporter:
    Mircea Carasel
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: