Spark

Improved last activity recognition

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.3
  • Fix Version/s: 2.7.0
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

http://community.igniterealtime.org/thread/45068

Here's a patch to query a contact's last acitivty and show the info in the contact pop up, if they're not available. If the contact is away, it will show how long the user has been idle or, if they are offline, when they logged off.

The only issue is Spark/Smack doesn't respond properly, but it would work with clients that handle a last activity query correctly. Spark/Smack does respond, it just resets the idle time on any packet delivery so the information from the contact is not accurate. The Openfire server does respond properly when a user is offline.

relates to Smack-345

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. SMACK-345 Inproved detection of last activity

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Jentz added a comment -

patch commited to svn

Show
Tim Jentz added a comment - patch commited to svn
Hide
Permalink
wroot added a comment -

I don't get what this patch does. I have compiled the latest version and i don't see what does this add. There is no info in the vcard popup or anything new in the Last Activity window.

Show
wroot added a comment - I don't get what this patch does. I have compiled the latest version and i don't see what does this add. There is no info in the vcard popup or anything new in the Last Activity window.
Hide
Permalink
D added a comment -

Without the SMACK-345 patch, it probably won't work.

Show
D added a comment - Without the SMACK-345 patch, it probably won't work.
Hide
Permalink
wroot added a comment -

I see. But the current Spark installer, bundled with JRE6 makes my Spark go offline when i hover a transports contact and a vcard popup is shown. This doesn't happen when i compile Spark with JDK7.

Show
wroot added a comment - I see. But the current Spark installer, bundled with JRE6 makes my Spark go offline when i hover a transports contact and a vcard popup is shown. This doesn't happen when i compile Spark with JDK7.
Hide
Permalink
Walter Ebeling added a comment -

Wroot: For clarification: Does your "external network contact" have a real Vcard image? My contacts do not have that and I can not reproduce your observation. My connections stays.

With repsect to Smack-345: We are in discussion with rcollier, if he wants to include 345 in the next Smack.

Show
Walter Ebeling added a comment - Wroot: For clarification: Does your "external network contact" have a real Vcard image? My contacts do not have that and I can not reproduce your observation. My connections stays. With repsect to Smack-345: We are in discussion with rcollier, if he wants to include 345 in the next Smack.
Hide
Permalink
wroot added a comment -

What is "real Vcard image"? Avatar? You can take Daryl Herzmann as an example, i have his contact via xmpp transport in my Spark. His profile only has a nickname, no avatar, anything.

Show
wroot added a comment - What is "real Vcard image"? Avatar? You can take Daryl Herzmann as an example, i have his contact via xmpp transport in my Spark. His profile only has a nickname, no avatar, anything.
Hide
Permalink
Lemon Yogster added a comment -

Yeah, it doesn't work without the Smack patch. That's why in the description it says that Spark (really Smack) doesn't respond properly and that it relates to it Smack patch-345. If the other user had a client that did respond properly, you should see the idle info. If the person was away, I'm surprised it didn't show any idle the first time you hovered or 0 min idle.

Show
Lemon Yogster added a comment - Yeah, it doesn't work without the Smack patch. That's why in the description it says that Spark (really Smack) doesn't respond properly and that it relates to it Smack patch-345. If the other user had a client that did respond properly, you should see the idle info. If the person was away, I'm surprised it didn't show any idle the first time you hovered or 0 min idle.
Hide
Permalink
Tim Jentz added a comment -

@wroot, i'll try to reproduce this behavior.

In my tests, the idle info is even shown without the smack patch. But the time you receive from a client running smack without the patch is tendentially wrong because even the answer for the request of the idle time is handled as an activity of the user.

Show
Tim Jentz added a comment - @wroot, i'll try to reproduce this behavior. In my tests, the idle info is even shown without the smack patch. But the time you receive from a client running smack without the patch is tendentially wrong because even the answer for the request of the idle time is handled as an activity of the user.
Hide
Permalink
wroot added a comment -

Oh, i get it now. It only works between Smack clients. I thought Spark wasn't getting correct info from the server. I have tried with two Spark clients and i see Idle < 1 min in the popup now.

Show
wroot added a comment - Oh, i get it now. It only works between Smack clients. I thought Spark wasn't getting correct info from the server. I have tried with two Spark clients and i see Idle < 1 min in the popup now.
Hide
Permalink
debasishpaul added a comment -

hi

Show
debasishpaul added a comment - hi
Hide
Permalink
Walter Ebeling added a comment -

Mass closing of resolved issues

Show
Walter Ebeling added a comment - Mass closing of resolved issues

People

  • Assignee:
    Tim Jentz
    Reporter:
    Walter Ebeling
Vote (2)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: