Spark

Group Chat - Actions/Start a conference menu: propose bookmarked room (if any) instead of adhoc (random) room name

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.3
  • Fix Version/s: 2.7.0
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

When start group chat option is selected, a random room name is presented
Since XMPP has a concept of bookmarking room per user (XEP-0048), I think it would be nice to retrieve the user bookmarked room, if any, instead of presenting a random room name

In addition, in a chat window, clicking on group-chat icon, the bookmarked room will be opened instead of creating a random room.

If there are more than one bookmarks, there will be a way to mark a default bookmark by changing the selection in Actions/Start group chat window

  1. Text File
    SPARK-1381.patch
    07/04/11 03:52 AM
    11 kB
    Mircea Carasel
  1. inviteFromChatWindow.png
    214 kB
    08/10/11 10:23 AM
  2. start_adhoc.png
    62 kB
    07/02/11 04:02 AM
  3. start_bookmarked.png
    96 kB
    07/02/11 04:02 AM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mircea Carasel added a comment -

I am attaching a patch that implements the requirement: SPARK-1381

Patch description:
-1. if there is no bookmarked room for the logged in user, there is no change, for "Room:", "Start a conference" menu displays a text input that shows an proposed ad-hoc room name: a new private conference room will be created (screenshot start_adhoc.png)

-2. if there is at least one bookmarked room, a combo-box will be displayed that will contain all bookmarked rooms. All users will be invited in THIS room (screenshot start_bookmarked.png).
The combo-box is editable. If you edit the room, all users will be invited in a new private conference r
oom (same as case 1)

Show
Mircea Carasel added a comment - I am attaching a patch that implements the requirement: SPARK-1381 Patch description: -1. if there is no bookmarked room for the logged in user, there is no change, for "Room:", "Start a conference" menu displays a text input that shows an proposed ad-hoc room name: a new private conference room will be created (screenshot start_adhoc.png) -2. if there is at least one bookmarked room, a combo-box will be displayed that will contain all bookmarked rooms. All users will be invited in THIS room (screenshot start_bookmarked.png). The combo-box is editable. If you edit the room, all users will be invited in a new private conference r oom (same as case 1)
Hide
Permalink
Mircea Carasel added a comment -

commited
r12565 = 4e3d084246970e9a9855abbfbc95f8438c850c49

Description

-Actions/Start a conference: will now show a combobox where you can select bookmarked conferences
the combo is editable so you can create a private room if desired with a chosen name
depending on the selection, in case there is more than one bookmark - the selected bookmark will be marked as default
if there is no bookmarked conference there will be the same behaviour: a random room-name will be proposed
-in a chat window, when group chat icon is pressed, the user will be automatically receive invite for the default bookmark instead of
creating a new room with random room-name

Show
Mircea Carasel added a comment - commited r12565 = 4e3d084246970e9a9855abbfbc95f8438c850c49 Description -Actions/Start a conference: will now show a combobox where you can select bookmarked conferences the combo is editable so you can create a private room if desired with a chosen name depending on the selection, in case there is more than one bookmark - the selected bookmark will be marked as default if there is no bookmarked conference there will be the same behaviour: a random room-name will be proposed -in a chat window, when group chat icon is pressed, the user will be automatically receive invite for the default bookmark instead of creating a new room with random room-name
Hide
Permalink
wroot added a comment -

Do not agree with the current behavior. I have only one room bookmarked and i don't want to join it if i just want an adhoc conference with one or two other users. Please make your custom behavior optional (in Preferences) and make it disabled by default. Ad-hoc rooms are ment to be temporary and random.

Show
wroot added a comment - Do not agree with the current behavior. I have only one room bookmarked and i don't want to join it if i just want an adhoc conference with one or two other users. Please make your custom behavior optional (in Preferences) and make it disabled by default. Ad-hoc rooms are ment to be temporary and random.
Hide
Permalink
Mircea Carasel added a comment - - edited

As required - I marked the feature optional - disabled by default

r12567 = f7bb1f912a435e6a68bc9d0ae45401fc3684e7ba

Description

-make the feature optional, disabled by default by adding "useAdHocRoom" preference option defaulted to true

Show
Mircea Carasel added a comment - - edited As required - I marked the feature optional - disabled by default r12567 = f7bb1f912a435e6a68bc9d0ae45401fc3684e7ba Description -make the feature optional, disabled by default by adding "useAdHocRoom" preference option defaulted to true
Hide
Permalink
Mircea Carasel added a comment -

commited:

r12570 = 7e2b8bda2a24e446138dab8bcb6f97930f116218

description

add checkbox to enable/disable automatically invitation to bookmarked room in Preferences/Group Chat panel

Show
Mircea Carasel added a comment - commited: r12570 = 7e2b8bda2a24e446138dab8bcb6f97930f116218 description add checkbox to enable/disable automatically invitation to bookmarked room in Preferences/Group Chat panel
Hide
Permalink
Walter Ebeling added a comment -

Mass closing of resolved issues

Show
Walter Ebeling added a comment - Mass closing of resolved issues

People

  • Assignee:
    Mircea Carasel
    Reporter:
    Mircea Carasel
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: