Smack

Use unique Thread names among connections

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.4.1
  • Fix Version/s: 3.0.0 Beta 1
  • Component/s: Core
  • Labels:
    None

Description

PacketReader creates 2 threads in the constructor with a static name so the name will be the same if we have many readers for many connections.

PacketWriter creats 3 threads in the constructor. Two of them have a static name whilst the last thread has no name.

Notify this thread when done:
http://www.jivesoftware.org/forums/thread.jspa?threadID=14385&tstart=0

Activity

Hide
Permalink
Matt Tucker added a comment -

When creating the threads, we don't yet have the username of the user that's logging in. We also don't have the connection ID from the server. Therefore, I created a new connection counter in XMPPConnection. All threads that get created then use a unique ID for the connection. Nice things about this value:

  • You can easily tell which threads are older than others by looking at the number.
  • The number stays consistent between connects and disconnects to the server (this could be a good or bad thing).
Show
Matt Tucker added a comment - When creating the threads, we don't yet have the username of the user that's logging in. We also don't have the connection ID from the server. Therefore, I created a new connection counter in XMPPConnection. All threads that get created then use a unique ID for the connection. Nice things about this value: You can easily tell which threads are older than others by looking at the number. The number stays consistent between connects and disconnects to the server (this could be a good or bad thing).

People

  • Assignee:
    Matt Tucker
    Reporter:
    Gaston Dombiak
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: