Smack

smack throw NoSuchElementException if the muc#roominfo_subject has no values

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.2.1
  • Fix Version/s: 3.2.2
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

I reviewed this issue for Spark-1462 and it seems that its an error related to smack.
If the subject is for that I reviewed this issue for Spark and it seems that its an error related to smack.

Smack checks if there is a muc#roominfo_subject element but not, if that element has any values.
This can cause NoSuchElementException in RoomInfo.java.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SPARK-1462 Spark doesn't list rooms when subject has a null value

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Jentz added a comment -

This patch should solve this problem by checking if the subject has any values.

Show
Tim Jentz added a comment - This patch should solve this problem by checking if the subject has any values.
Tim Jentz made changes -
Field Original Value New Value
Attachment Smack-362_RoomInfo_SubjectNull.patch [ 11370 ]
wroot made changes -
Link This issue is related to SPARK-1462 [ SPARK-1462 ]
Hide
Permalink
Tim Jentz added a comment -

Since i think the description field could cause the same problem like the subject field, i updated the patch to check the description values too.

Show
Tim Jentz added a comment - Since i think the description field could cause the same problem like the subject field, i updated the patch to check the description values too.
Tim Jentz made changes -
Attachment Smack-362_RoomInfo_SubjectDescription.patch [ 11374 ]
Robin Collier made changes -
Status Open [ 1 ] In Progress [ 3 ]
Robin Collier made changes -
Status In Progress [ 3 ] Open [ 1 ]
Robin Collier made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Robin Collier added a comment -

Added modified version of patch. The patch returned "n/a" instead of "", which was what was being returned before. This has the potential for breaking existing code since any check for an empty string would fail.

Show
Robin Collier added a comment - Added modified version of patch. The patch returned "n/a" instead of "", which was what was being returned before. This has the potential for breaking existing code since any check for an empty string would fail.
Robin Collier made changes -
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Robin Collier
    Reporter:
    Tim Jentz
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: