Rework File Transfer

Details

Type: Bug
Status: Resolved
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.2.1
Fix Version/s: 3.3.0
Component/s: None
Labels:
None

Acceptance Test - Add?:
No

Description

This is the Master Ticket for file transfer bugs.

For reference, these are the links to the changes by Henning:
http://community.igniterealtime.org/message/200840#200840
http://community.igniterealtime.org/message/202593#202593

It was committed as rev 11815 and rev. 11822

The code of Henning was extensively reviewed by Tim Jentz and tested by Walter Ebeling. Several changes of the community were combined and additional changes were made to make file transfer via bytestream, bytestream via proxy and IBB working in Spark 2.6.3 again.

Especially IBB file transfer needed to change from IQ stanzas to message stanzas to allow IBB again. This is breaks the attempted full implementation of XEP-0047 that is not working without errors when using IQ Stanzas.

The patch combined fixes for a couple of sub tasks to this master ticket. Namely
smack-263
smack-335
smack-349
smack-334

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

bytestreamPatch_19.09.11.patch

09/19/11 10:17 AM

0.9 kB

Tim Jentz
IBBfix_beta.patch

09/07/11 01:58 AM

8 kB

Walter Ebeling
localProxy_19.09.11.patch

09/19/11 10:24 AM

1 kB

Tim Jentz
smack-351.patch

09/09/11 10:48 AM

10 kB

Walter Ebeling

Options
- Show All
- Show Open

Sub-Tasks

1.	Need to set file size and name for outgoing file transfer from input stream	Closed	Robin Collier
2.	Smack's IBB sends too much data in a packet	Resolved	Robin Collier
3.	Set file info in all send* methods	Resolved	Robin Collier
4.	IBB filetransfer doesn't work as expected	Closed	Robin Collier
5.	Bug in return code for rejection handling in FileTransferManager	Resolved	Robin Collier
6.	Thread leak in the FaultTolerantNegotiator	Resolved	Robin Collier
7.	Bytestream is not working in Spark 2.6.3 from XP to W7	Closed	Robin Collier
8.	IO Error if smack cant use port for local proxy	Closed	Florian Schmaus

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Walter Ebeling added a comment - 09/07/11 02:01 AM

Please review the patch and consider a commit.

Show

Walter Ebeling added a comment - 09/07/11 02:01 AM Please review the patch and consider a commit.

Hide

Permalink

Walter Ebeling added a comment - 09/07/11 02:31 AM

Please provide von unit and integration tests to the patch

Show

Walter Ebeling added a comment - 09/07/11 02:31 AM Please provide von unit and integration tests to the patch

Walter Ebeling made changes - 09/07/11 02:31 AM

Field	Original Value	New Value
Assignee	Robin Collier [ rcollier ]	Tim Jentz [ timjentz ]

Hide

Permalink

Walter Ebeling added a comment - 09/08/11 12:56 PM

Following the discussion in http://community.igniterealtime.org/blogs/ignite/2011/09/02/smack-322-beta-fixes-ibb-transfer#comments I would ask to change the patch to keep list-single. The impact is "only" a breakage of IBB file transfers for Spark 2.5.8 client. Users of 2.5.8 can do file transfer via bytestream. It's a clearly visible issue in mixed environment and has to be documented in the release notes of Spark 2.7.0

Show

Walter Ebeling added a comment - 09/08/11 12:56 PM Following the discussion in http://community.igniterealtime.org/blogs/ignite/2011/09/02/smack-322-beta-fixes-ibb-transfer#comments I would ask to change the patch to keep list-single. The impact is "only" a breakage of IBB file transfers for Spark 2.5.8 client. Users of 2.5.8 can do file transfer via bytestream. It's a clearly visible issue in mixed environment and has to be documented in the release notes of Spark 2.7.0

Hide

Permalink

Walter Ebeling added a comment - 09/09/11 10:48 AM

reworked patch with list-single instead of list-multi as discussed in http://community.igniterealtime.org/message/216450#216450

includes patch for smack-346

Show

Walter Ebeling added a comment - 09/09/11 10:48 AM reworked patch with list-single instead of list-multi as discussed in http://community.igniterealtime.org/message/216450#216450 includes patch for smack-346

Walter Ebeling made changes - 09/09/11 10:48 AM

Attachment

smack-351.patch [ 11240 ]

Hide

Permalink

Walter Ebeling added a comment - 09/09/11 10:51 AM

smack-351.patch is the latest version of the patch

Show

Walter Ebeling added a comment - 09/09/11 10:51 AM smack-351.patch is the latest version of the patch

Hide

Permalink

Tim Jentz added a comment - 09/19/11 10:17 AM

When Receiver of Bytestream answer the disc#info message, two messages are send.
The first message is the normal result message, the second message is the message which includes the needed information for the sender.
If the second message arrives to late, the sender decides that the receiver cant use bytestream and sends data in ibb.

This patch adds a 200ms sleep, so the sender has enough time to decide.

It's currently a bit quick&dirty, i will rework but for now, its good for testing purposes.

Show

Tim Jentz added a comment - 09/19/11 10:17 AM When Receiver of Bytestream answer the disc#info message, two messages are send. The first message is the normal result message, the second message is the message which includes the needed information for the sender. If the second message arrives to late, the sender decides that the receiver cant use bytestream and sends data in ibb. This patch adds a 200ms sleep, so the sender has enough time to decide. It's currently a bit quick&dirty, i will rework but for now, its good for testing purposes.

Tim Jentz made changes - 09/19/11 10:17 AM

Attachment

bytestreamPatch_19.09.11.patch [ 11247 ]

Hide

Permalink

Tim Jentz added a comment - 09/19/11 10:24 AM

If a user try to run two clients on the same machine with local proxy, the second client can't establish a socket to the same port the first client is using (7777 per default).
If the default port is less then zero, smack will try to find a port which is not used. If the default port is above zero, smack want to use the specific port which can throw a IO Exception.

This patch make smack to search for a free port if the default port cant be used.

Show

Tim Jentz added a comment - 09/19/11 10:24 AM If a user try to run two clients on the same machine with local proxy, the second client can't establish a socket to the same port the first client is using (7777 per default). If the default port is less then zero, smack will try to find a port which is not used. If the default port is above zero, smack want to use the specific port which can throw a IO Exception. This patch make smack to search for a free port if the default port cant be used.

Tim Jentz made changes - 09/19/11 10:24 AM

Attachment

localProxy_19.09.11.patch [ 11248 ]

Robin Collier made changes - 10/21/11 05:20 PM

Assignee

Tim Jentz [ timjentz ]

Robin Collier [ rcollier ]

Hide

Permalink

Robin Collier added a comment - 10/21/11 06:17 PM

For future note, patches belong with the specific issue that they resolve, not the parent task. In addition, most comments are relevant to specific issues and also belong there.

Show

Robin Collier added a comment - 10/21/11 06:17 PM For future note, patches belong with the specific issue that they resolve, not the parent task. In addition, most comments are relevant to specific issues and also belong there.

Robin Collier made changes - 12/21/11 07:13 PM

Fix Version/s		3.3.0 [ 10911 ]
Fix Version/s	3.2.2 [ 10924 ]

Florian Schmaus made changes - 01/28/13 08:37 AM

Description

This is the Master Ticket for file transfer bugs introduced by the work of Henning Staib

For reference, these are the links to the changes by Henning:
http://community.igniterealtime.org/message/200840#200840
http://community.igniterealtime.org/message/202593#202593

It was committed as rev 11815 and rev. 11822

The code of Henning was extensively reviewed by Tim Jentz and tested by Walter Ebeling. Several changes of the community were combined and additional changes were made to make file transfer via bytestream, bytestream via proxy and IBB working in Spark 2.6.3 again.

Especially IBB file transfer needed to change from IQ stanzas to message stanzas to allow IBB again. This is breaks the attempted full implementation of XEP-0047 that is not working without errors when using IQ Stanzas.

The patch combined fixes for a couple of sub tasks to this master ticket. Namely
smack-263
smack-335
smack-349
smack-334

This is the Master Ticket for file transfer bugs.

For reference, these are the links to the changes by Henning:
http://community.igniterealtime.org/message/200840#200840
http://community.igniterealtime.org/message/202593#202593

It was committed as rev 11815 and rev. 11822

The code of Henning was extensively reviewed by Tim Jentz and tested by Walter Ebeling. Several changes of the community were combined and additional changes were made to make file transfer via bytestream, bytestream via proxy and IBB working in Spark 2.6.3 again.

Especially IBB file transfer needed to change from IQ stanzas to message stanzas to allow IBB again. This is breaks the attempted full implementation of XEP-0047 that is not working without errors when using IQ Stanzas.

The patch combined fixes for a couple of sub tasks to this master ticket. Namely
smack-263
smack-335
smack-349
smack-334

Robin Collier made changes - 02/03/13 08:46 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

People

Assignee:

Robin Collier

Reporter:

Walter Ebeling

Vote (0)

Watch (0)

Dates

Created:

09/07/11 01:58 AM

Updated:

02/03/13 08:46 PM

Resolved:

02/03/13 08:46 PM