Smack

IBB filetransfer doesn't work as expected

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Won't Fix
  • Affects Version/s: 3.2.1
  • Fix Version/s: 3.2.2
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

There are a lot of Problems using Spark 2.6.0 with Smack 3.2.0.
We tested file transfer with following configurations:

Spark 2.6.0 Smack 3.2.0, Win XP
Spark 2.5.8 Smack 3.0.0 Win XP

Local PC Working transfer directions VPN PC Protocol
2.6.0 --> 2.6.0 Socks5Bytestream
2.6.0 --> 2.5.8 --> Socks5Bytestream
<-- IBB
2.5.8 Both 2.5.8 Both IBB
2.5.8 --> 2.6.0 Both Socks5Bytestream

It seems to me that smack 3.2.0 is not able to handle IBB. It should use this protocol as fallback for socks5bytestream. Especially when you are behind a firewall or connecting through vpn it's necessary to use the IBB transfer mode.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SPARK-1283 File transfer between 2.5.8 and 2.6.0_12222 is broken

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Walter Ebeling added a comment -

This is also happening for Smack 3.1.0. I have checke Spark Build 79 that has Smack 3.1.0 as base. Spark 2.5.8 with Smack 3.0.0 is working.

Show
Walter Ebeling added a comment - This is also happening for Smack 3.1.0. I have checke Spark Build 79 that has Smack 3.1.0 as base. Spark 2.5.8 with Smack 3.0.0 is working.
Walter Ebeling made changes -
Field Original Value New Value
Priority Major [ 3 ] Critical [ 2 ]
Hide
Permalink
Walter Ebeling added a comment -

Might related to http://issues.igniterealtime.org/browse/SMACK-309

Other relevant changes:
SMACK-303
SMACK-302
SMACK-301
SMACK-300
SMACK-299
SMACK-298
SMACK-297

And an open issue

http://issues.igniterealtime.org/browse/SMACK-239

Show
Walter Ebeling added a comment - Might related to http://issues.igniterealtime.org/browse/SMACK-309 Other relevant changes: SMACK-303 SMACK-302 SMACK-301 SMACK-300 SMACK-299 SMACK-298 SMACK-297 And an open issue http://issues.igniterealtime.org/browse/SMACK-239
Walter Ebeling made changes -
Link This issue is related to SPARK-1283 [ SPARK-1283 ]
Hide
Create a new review for changeset 12409
holger.bergunde submitted changeset 12409 to smack_3_2_0 in smack (1 file) - 05/23/11 09:11 AM

SMACK-338 this should use IBB as fallback protocol if available

Show
Create a new review for changeset 12409
holger.bergunde submitted changeset 12409 to smack_3_2_0 in smack (1 file) - 05/23/11 09:11 AM
Holger Bergunde made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Walter Ebeling added a comment -

Still massive problems

Show
Walter Ebeling added a comment - Still massive problems
Walter Ebeling made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Robin Collier [ rcollier ] Walter Ebeling [ webeling ]
Walter Ebeling made changes -
Assignee Walter Ebeling [ webeling ] Tim Jentz [ timjentz ]
Walter Ebeling made changes -
Fix Version/s 3.2.2 [ 10924 ]
Fix Version/s 3.2.1 [ 10910 ]
Affects Version/s 3.2.1 [ 10910 ]
Affects Version/s 3.2.0 [ 10841 ]
Hide
Permalink
Tim Jentz added a comment -

Patch smack to use message mode in IBB. Also included: smack-263, smack-335, smack-349.
Undo changes made by smack-334.

Show
Tim Jentz added a comment - Patch smack to use message mode in IBB. Also included: smack-263, smack-335, smack-349. Undo changes made by smack-334.
Tim Jentz made changes -
Attachment IBBfix_beta.patch [ 11233 ]
Walter Ebeling made changes -
Parent SMACK-351 [ 16496 ]
Issue Type Bug [ 1 ] Sub-task [ 5 ]
Hide
Permalink
Walter Ebeling added a comment -

The different Spark bug reports relate to several root causes:

1) Spark 2.6.3 uses IQ stanzas in IBB to transfer files. Spark 2.5.8 dos not understand IQ stanzas.

2) Spark 2.5.8 uses during negotiation a statement list-multi, which should be list-single. This causes broken negotiations.

3) Spark 2.6.3 and 2.5.8 were using multiple discovery managers that were causing failures of IBB. This is not a Smack bug.

Smack should us IQ stanzas for file transfer since it is the more advance standard. Usage of list-single during negotiation is XEP standard (in contrast to the list-multi used by Spark 2.5.8).

Show
Walter Ebeling added a comment - The different Spark bug reports relate to several root causes: 1) Spark 2.6.3 uses IQ stanzas in IBB to transfer files. Spark 2.5.8 dos not understand IQ stanzas. 2) Spark 2.5.8 uses during negotiation a statement list-multi, which should be list-single. This causes broken negotiations. 3) Spark 2.6.3 and 2.5.8 were using multiple discovery managers that were causing failures of IBB. This is not a Smack bug. Smack should us IQ stanzas for file transfer since it is the more advance standard. Usage of list-single during negotiation is XEP standard (in contrast to the list-multi used by Spark 2.5.8).
Walter Ebeling made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Assignee Tim Jentz [ timjentz ] Robin Collier [ rcollier ]
Resolution Won't Fix [ 2 ]

People

  • Assignee:
    Robin Collier
    Reporter:
    Holger Bergunde
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: