Smack

Only fire RosterListener#entriesUpdated for RosterEntries that changed

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

The RosterPacketListener adds roster entries to the list of updated entries without checking if the entry actually changed. This causes unnecessary notifications to the RosterListeners although there is no new information available for an entry.

The attached patch fixes this bug by implementeng a new #equalsDeep() method for RosterEntry which determines equality using all members of the RosterEntry class.
The RosterPacketListener now only adds the entry to the updated entries if #equalsDeep() compared with the old entry returns false.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SPARK-1242 Group disappears after a rename.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. SMACK-35 Add roster listener support

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Henning Staib added a comment -

fixed in revision 11827

Show
Henning Staib added a comment - fixed in revision 11827
Hide
Permalink
Walter Ebeling added a comment -

Prevents group renaming in Spark build 79.

Show
Walter Ebeling added a comment - Prevents group renaming in Spark build 79.
Hide
Permalink
Walter Ebeling added a comment -

Roll back to a version prior the check in of this change allows a rename of groups

Show
Walter Ebeling added a comment - Roll back to a version prior the check in of this change allows a rename of groups
Hide
Permalink
Holger Bergunde added a comment -

when i change the group name in spark with smack 2.3.0b2 the renamed group will disappear.
spark does the following:

RosterGroup rosterGroup = roster.getGroup(groupName);
if (rosterGroup != null)

{ removeContactGroup(group); rosterGroup.setName(newName); }

the "deepquals" method of the RosterEntry doesn't seem to work properly. when the name is changed deepmethod says that the classes are equals even though they have different names!

Show
Holger Bergunde added a comment - when i change the group name in spark with smack 2.3.0b2 the renamed group will disappear. spark does the following: RosterGroup rosterGroup = roster.getGroup(groupName); if (rosterGroup != null) { removeContactGroup(group); rosterGroup.setName(newName); } the "deepquals" method of the RosterEntry doesn't seem to work properly. when the name is changed deepmethod says that the classes are equals even though they have different names!
Hide
Permalink
Walter Ebeling added a comment -

Patch extended in rev 12087

Show
Walter Ebeling added a comment - Patch extended in rev 12087
Hide
Permalink
wroot added a comment -

Another patch proposition. http://community.igniterealtime.org/message/210486#210486

Show
wroot added a comment - Another patch proposition. http://community.igniterealtime.org/message/210486#210486
Hide
Permalink
Robin Collier added a comment -

Apparently there are still issues with changing roster entries.

Show
Robin Collier added a comment - Apparently there are still issues with changing roster entries.

People

  • Assignee:
    Unassigned
    Reporter:
    Henning Staib
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: