Smack

RosterEntry#getGroups causing a roster reload

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.1.0
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

René Treffer wrotes:

So here is what many users do:
1. Disable roster loading on login
2. getRoster
3. Iterate over all Entries
4. call getGroups on every Entry, thus reloading their roster multiple times

This was made possible by the connection.roster -> connection.getRoster change. I actually think the getRoster logic is broken, as it should never reload the roster unless it need initialization (reload is getRoster().reload(), right?).

Issue Links

is related to

Sub-task - The sub-task of the issue SMACK-279 Create a abstract connection class to allow other implementations connecting to a XMPP server.

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guenther Niess added a comment -

I'm not sure that the described scenario is widely-used and if we change the getRoster logic, we will break some applications or get problems with the reconnection logic. I think it was intended that the most users will iterate over all Roster#getGroups and RosterGroup#getEntries. But the described scenario is possible and produces too much traffic.

Show
Guenther Niess added a comment - I'm not sure that the described scenario is widely-used and if we change the getRoster logic, we will break some applications or get problems with the reconnection logic. I think it was intended that the most users will iterate over all Roster#getGroups and RosterGroup#getEntries. But the described scenario is possible and produces too much traffic.
Hide
Permalink
René Treffer added a comment -

The iteration over all entries + getGroup is quite common. It's the usual way to build your roster.

I've actually a problem with "loadRosterOnLogin" meaning "don't reload the roster all the time". Especially as getGroups -> getRoster was introduced with the BOSH merge

Show
René Treffer added a comment - The iteration over all entries + getGroup is quite common. It's the usual way to build your roster. I've actually a problem with "loadRosterOnLogin" meaning "don't reload the roster all the time". Especially as getGroups -> getRoster was introduced with the BOSH merge
Hide
Permalink
Guenther Niess added a comment -

Your right, I should have a more detailed look into this.

Show
Guenther Niess added a comment - Your right, I should have a more detailed look into this.
Hide
Permalink
Guenther Niess added a comment -

This issue was introduced by SMACK-279.

Show
Guenther Niess added a comment - This issue was introduced by SMACK-279 .
Hide
Permalink
Guenther Niess added a comment -

I don't really want to change the Connection#getRoster logic, so I've fixed it within the RosterEntry and Roster class and committed a patch to 11670.

Show
Guenther Niess added a comment - I don't really want to change the Connection#getRoster logic, so I've fixed it within the RosterEntry and Roster class and committed a patch to 11670.

People

  • Assignee:
    Guenther Niess
    Reporter:
    Guenther Niess
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: