error presence packets when server is down

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0.4
  • Fix Version/s: 3.1.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

http://www.igniterealtime.org/community/message/182768

In smack 3.0.4, error presence packets like this are not handled:

<presence to="mobi@ubithere.com/CellPhone" from="vbarat@lancelot" type="error"><error code="404" type="CANCEL"><remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/></error></presence>

This happens when a server is down.

But the Roster doesn't process these packets so we have the wrong Presence when asking the Roster about the user.

Here is my attached patch:

Activity

Hide
Permalink
Matt Tucker added a comment -

Cool, I will check this out and get it into place.

Tip for filing bugs in the future: the "fix for" date is much more important than the "affects" version since that's what we use when looking at filters of what still needs to get done in order to get a release out the door. The affects value in this case could have been 3.0.x since the bug exists there. In general, the "affects" value only seems to be especially useful for regressions.

Show
Matt Tucker added a comment - Cool, I will check this out and get it into place. Tip for filing bugs in the future: the "fix for" date is much more important than the "affects" version since that's what we use when looking at filters of what still needs to get done in order to get a release out the door. The affects value in this case could have been 3.0.x since the bug exists there. In general, the "affects" value only seems to be especially useful for regressions.

People

  • Assignee:
    Matt Tucker
    Reporter:
    Daryl Herzmann
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: