Smack

Better handling of Roster error

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

If there is an error in the server side by adding a new contact, Smack raises an exception that makes Spark goes down.

java.lang.NullPointerException: Name is null
at java.lang.Enum.valueOf(Unknown Source)
at org.jivesoftware.smack.packet.RosterPacket$ItemType.valueOf(RosterPacket.java:268)
at org.jivesoftware.smack.PacketReader.parseRoster(PacketReader.java:697)
at org.jivesoftware.smack.PacketReader.parseIQ(PacketReader.java:582)
at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:275)
at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:44)
at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:76)

These are the stanzas that cause the error:
Openfire RCV: <iq id="3Rqm2-48" type="set" from="95c7a9c5@server1/95c7a9c5"><query xmlns="jabber:iq:roster"><item jid="tsung1@server2"
name="tsung1"><group>Friends</group></item></query></iq>
Openfire SENT: <iq type="error" id="3Rqm2-48" to="95c7a9c5@server1/95c7a9c5"><query xmlns="jabber:iq:roster"><item jid="tsung1@server2"
name="tsung1"><group>Friends</group></item></query><error code="500" type="wait"><internal-server-error xmlns="urn:ietf
:params:xml:ns:xmpp-stanzas"/></error></iq>

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. SMACK-293 Support optional roster subscription attribute

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
is related to

Improvement - An improvement or enhancement to an existing feature or task. SMACK-252 Soften Smack's response to certain kinds of well-formed, but otherwise defective XML packets

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yoav Zibin added a comment -

Yes, I got the exact same error!
I can't use SMACK because it keeps disconnecting every time this exception occurs.
Does anyone has a fix for it?

java.lang.NullPointerException: Name is null
at java.lang.Enum.valueOf(Enum.java:191)
at org.jivesoftware.smack.packet.RosterPacket$ItemType.valueOf(RosterPacket.java:268)
at org.jivesoftware.smack.PacketReader.parseRoster(PacketReader.java:697)
at org.jivesoftware.smack.PacketReader.parseIQ(PacketReader.java:582)
at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:275)
at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:44)
at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:76)

Show
Yoav Zibin added a comment - Yes, I got the exact same error! I can't use SMACK because it keeps disconnecting every time this exception occurs. Does anyone has a fix for it? java.lang.NullPointerException: Name is null at java.lang.Enum.valueOf(Enum.java:191) at org.jivesoftware.smack.packet.RosterPacket$ItemType.valueOf(RosterPacket.java:268) at org.jivesoftware.smack.PacketReader.parseRoster(PacketReader.java:697) at org.jivesoftware.smack.PacketReader.parseIQ(PacketReader.java:582) at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:275) at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:44) at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:76)
Hide
Permalink
Yoav Zibin added a comment -

I just wanted to note that I get this exception when connecting to GoogleTalk:
new ConnectionConfiguration("talk.google.com", 5222, "gmail.com");

Assuming GoogleTalk adheres to the spec, then the bug must be in SMACK.
Instead of disconnecting, SMACK should give a callback to the user who can write a custom error handling routine.

Show
Yoav Zibin added a comment - I just wanted to note that I get this exception when connecting to GoogleTalk: new ConnectionConfiguration("talk.google.com", 5222, "gmail.com"); Assuming GoogleTalk adheres to the spec, then the bug must be in SMACK. Instead of disconnecting, SMACK should give a callback to the user who can write a custom error handling routine.
Hide
Permalink
Yoav Zibin added a comment -

No, the same problem still happens.
I couldn't find the oficial release of 3.0.5, so I downloaded the SVN:
http://svn.igniterealtime.org/svn/repos/smack/trunk
And used ANT to build everything.
I still get:

java.lang.NullPointerException: Name is null
at java.lang.Enum.valueOf(Enum.java:191)
at org.jivesoftware.smack.packet.RosterPacket$ItemType.valueOf(RosterPacket.java:268)
at org.jivesoftware.smack.PacketReader.parseRoster(PacketReader.java:697)
at org.jivesoftware.smack.PacketReader.parseIQ(PacketReader.java:582)
at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:275)
at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:44)
at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:76)

And I connect to GTalk, so I assume the bug is in SMACK....

Show
Yoav Zibin added a comment - No, the same problem still happens. I couldn't find the oficial release of 3.0.5, so I downloaded the SVN: http://svn.igniterealtime.org/svn/repos/smack/trunk And used ANT to build everything. I still get: java.lang.NullPointerException: Name is null at java.lang.Enum.valueOf(Enum.java:191) at org.jivesoftware.smack.packet.RosterPacket$ItemType.valueOf(RosterPacket.java:268) at org.jivesoftware.smack.PacketReader.parseRoster(PacketReader.java:697) at org.jivesoftware.smack.PacketReader.parseIQ(PacketReader.java:582) at org.jivesoftware.smack.PacketReader.parsePackets(PacketReader.java:275) at org.jivesoftware.smack.PacketReader.access$000(PacketReader.java:44) at org.jivesoftware.smack.PacketReader$1.run(PacketReader.java:76) And I connect to GTalk, so I assume the bug is in SMACK....
Hide
Permalink
Kirill Maximov added a comment -

TeamCity project suffers from this problem as well: http://www.jetbrains.net/tracker/issue2/TW-6100

Show
Kirill Maximov added a comment - TeamCity project suffers from this problem as well: http://www.jetbrains.net/tracker/issue2/TW-6100
Hide
Permalink
Guenther Niess added a comment -

I suppose this should be related to SMACK-293 and fixed in the current trunk version. Sorry for duplicating this bug :-/ Please verify this and comment on this issue.

Show
Guenther Niess added a comment - I suppose this should be related to SMACK-293 and fixed in the current trunk version. Sorry for duplicating this bug :-/ Please verify this and comment on this issue.
Hide
Permalink
Guenther Niess added a comment -

Is already fixed on revision 11642.

Show
Guenther Niess added a comment - Is already fixed on revision 11642.

People

  • Assignee:
    Matt Tucker
    Reporter:
    Francisco Vives
Vote (5)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: