Smack

Fix NPE in RoomInfo when subject has not value

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2.1
  • Fix Version/s: 3.0.0 Beta 1, 3.2.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

When muc#roominfo_subject contains no value then Smack will fail with a NPE.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brent Easton added a comment -

This issue is not fixed, the patch does not work correctly.

This is still an issue in v3.1.0. RoomInfo ctor throws an NPE when connecting to an ejabberd server.

The code was changed from

this.subject = form.getField("muc#roominfo_subject").getValues().next();

to

Iterator<String> values = form.getField("muc#roominfo_subject").getValues();
if (values.hasNext())

{ this.subject = values.next(); }

else

{ this.subject = ""; }

The correct fix is:

final FormField subjField = form.getField("muc#roominfo_subject");
this.subject = subjField == null ? "" : subjField.getValues().next();

Note that description has potentially the same problem.

Show
Brent Easton added a comment - This issue is not fixed, the patch does not work correctly. This is still an issue in v3.1.0. RoomInfo ctor throws an NPE when connecting to an ejabberd server. The code was changed from this.subject = form.getField("muc#roominfo_subject").getValues().next(); to Iterator<String> values = form.getField("muc#roominfo_subject").getValues(); if (values.hasNext()) { this.subject = values.next(); } else { this.subject = ""; } The correct fix is: final FormField subjField = form.getField("muc#roominfo_subject"); this.subject = subjField == null ? "" : subjField.getValues().next(); Note that description has potentially the same problem.
Hide
Permalink
Walter Ebeling added a comment -

According to a community report this has to reopen

http://community.igniterealtime.org/message/208940#208940

Show
Walter Ebeling added a comment - According to a community report this has to reopen http://community.igniterealtime.org/message/208940#208940
Hide
Permalink
Walter Ebeling added a comment -

Can you take a look into it and review, if we need that for 2.6.0 RC2 or 2.6.0 final?

Show
Walter Ebeling added a comment - Can you take a look into it and review, if we need that for 2.6.0 RC2 or 2.6.0 final?
Hide
Permalink
Robin Collier added a comment -

All three form fields accessed had the same issue and are now fixed.

Show
Robin Collier added a comment - All three form fields accessed had the same issue and are now fixed.

People

  • Assignee:
    Robin Collier
    Reporter:
    Gaston Dombiak
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: