Smack

MultiUserChat will Store Messages in its PacketCollector irregardless of whether or not they are being read

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.0, 2.1.0, 2.2.0, 2.2.1, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.1.0, 3.2.0
  • Fix Version/s: 3.2.1
  • Component/s: Extensions
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

MultiUserChat will store messages in a room, if many messages are recieved it will cause Smack to run out of memory.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. SMACK-6 Don't force use of collectors in Chat, GroupChat, etc

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Tucker added a comment -

We should likely make the fix like the one that Alex implemented for Chat – force passing in a listener when creating the room. Creating the collector should be optional.

Show
Matt Tucker added a comment - We should likely make the fix like the one that Alex implemented for Chat – force passing in a listener when creating the room. Creating the collector should be optional.
Hide
Permalink
Joshua Davis added a comment -

I see that MutiUserChat creates a ConnectionDetachedPacketListener which keeps a list of 65536 packets (MAX_PACKETS). Maybe that should be configurable rather than being a private static final field?

Show
Joshua Davis added a comment - I see that MutiUserChat creates a ConnectionDetachedPacketListener which keeps a list of 65536 packets (MAX_PACKETS). Maybe that should be configurable rather than being a private static final field?
Hide
Permalink
Robin Collier added a comment -

Made the packet collectors max size configurable and set the default size much lower than the 65K it was set to.

Show
Robin Collier added a comment - Made the packet collectors max size configurable and set the default size much lower than the 65K it was set to.

People

  • Assignee:
    Robin Collier
    Reporter:
    Alex Wenckus
Vote (5)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: