Restore shared group support for read-only GroupProviders (LDAP)
Description
When the original reporter (see Ignite Forum URL) tries to share a group in the admin console, an error is logged.
Steps to reproduce (as reported)
Open to Group/User tab in WebAdmin Panel
Open Groups tab
Locate group
Enter in name for group sharing
Save Contact List
This issue is not reproducible on the igniterealtime.org domain, but has been confirmed by a second user in the Ignite Forum (see URL listed in this issue).
The relevant part of the error message is:
The JSP-code that is referenced there is this snippet of JSP:
The properties object that is in a Group instance is instantiated by the configured GroupProvider. This might be the reason why this problem is not reproducable on our domain, but is for other users. We're using a regular JDBC-based backend. I assume users using another type of backend (LDAP, ClearSpace) suffer from this issue.
This problem might be caused by this snippet from AbstractReadOnlyGroupProvider (introduced as part of OF-278:
This is likely to cause the properties for a group to be immutable, which would be a reasonable cause for the behavior described by the original reporter.
Environment
None
Activity
Show:
Tom Evans February 7, 2013 at 4:26 PM
Reported fixed in the latest nightly build; will be included with pending 3.8.1 release.
Tom Evans February 7, 2013 at 7:29 AM
Ref. CL 13455 - Presumed fixed, but needs additional testing with LDAP, JDBC, and Clearspace deployments.
Tom Evans February 7, 2013 at 2:36 AM
Yes, confirmed. In addressing the fix for it appears we inadvertently dropped shared groups support for read-only providers, particularly LDAP.
This will be corrected shortly - please watch this ticket for updates.
Adam Jacobs February 7, 2013 at 2:31 AM
Confirming that I am seeing this same bug. Running on ubuntu 12.10, with Active Directory LDAP for the user store. Shared groups are completely broken in this configuration.
Guus der Kinderen February 6, 2013 at 11:19 PM
Tom, as the author of the Group rewrite, could you have a look please?
When the original reporter (see Ignite Forum URL) tries to share a group in the admin console, an error is logged.
Steps to reproduce (as reported)
Open to Group/User tab in WebAdmin Panel
Open Groups tab
Locate group
Enter in name for group sharing
Save Contact List
This issue is not reproducible on the igniterealtime.org domain, but has been confirmed by a second user in the Ignite Forum (see URL listed in this issue).
The relevant part of the error message is:
The JSP-code that is referenced there is this snippet of JSP:
The
propertiesobject that is in a Group instance is instantiated by the configuredGroupProvider. This might be the reason why this problem is not reproducable on our domain, but is for other users. We're using a regular JDBC-based backend. I assume users using another type of backend (LDAP, ClearSpace) suffer from this issue.This problem might be caused by this snippet from
AbstractReadOnlyGroupProvider(introduced as part of OF-278:This is likely to cause the properties for a group to be immutable, which would be a reasonable cause for the behavior described by the original reporter.