Openfire

Loading and creating rooms with multiple conferences services fails

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 3.6.4
  • Fix Version/s: 3.7.0 beta
  • Component/s: Admin Console, MUC
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

There are issues with new multiple conferences services introduced in 3.6.0.:

  • Sometimes when creating new server it copies permanent room from previous service.
  • When trying to create room with same ID of the room in other service it throws an error, that such room already exists, but still lets you to create such room.

Issue Links

This issue is related to:
OF-27 Create conferences services with invalid service name Blocker Resolved
This issue is related to:
OF-33 Some issues with the first conference service which is manually created. Blocker Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Guenther Niess added a comment -

Split OF-27 into smaller issues for a better handling.

Show
Guenther Niess added a comment - Split OF-27 into smaller issues for a better handling.
Hide
Permalink
Guenther Niess added a comment -

This patch add the serviceID in the query for loading a conference room and fix a small bug in the admin console.

Show
Guenther Niess added a comment - This patch add the serviceID in the query for loading a conference room and fix a small bug in the admin console.
Hide
Permalink
wroot added a comment -

I think second issue with the same room names was fixed in a one of your patches from OF-27

Show
wroot added a comment - I think second issue with the same room names was fixed in a one of your patches from OF-27
Hide
Permalink
Guenther Niess added a comment -

Yes wroot, Guus and I decided to split the OF-27 into smaller issues. This allows a better discussion on the different bugs. Maybe you can delete the outdated createAndLoadRoom and repairDB patch from OF-27.

Show
Guenther Niess added a comment - Yes wroot, Guus and I decided to split the OF-27 into smaller issues. This allows a better discussion on the different bugs. Maybe you can delete the outdated createAndLoadRoom and repairDB patch from OF-27.
Hide
Permalink
wroot added a comment -

Done. I've also changed affect version back to 3.6.4.

Show
wroot added a comment - Done. I've also changed affect version back to 3.6.4.
Hide
Permalink
Guenther Niess added a comment -

Just a view words to explain the relation between the described bugs and the createAndLoadRoom.patch.
If someone tries to create or access a room which isn't present in the cache then the MultiUserChatServiceImpl#getChatRoom(String roomName, JID userjid) will be called. Here it tries the MUCPersistenceManager#loadFromDB method which doesn't respect the current service (it tries to load the room from all available services). This causes the described behavior of the bug and is fixed by the createAndLoadRoom patch.

Show
Guenther Niess added a comment - Just a view words to explain the relation between the described bugs and the createAndLoadRoom.patch. If someone tries to create or access a room which isn't present in the cache then the MultiUserChatServiceImpl#getChatRoom(String roomName, JID userjid) will be called. Here it tries the MUCPersistenceManager#loadFromDB method which doesn't respect the current service (it tries to load the room from all available services). This causes the described behavior of the bug and is fixed by the createAndLoadRoom patch.
Hide
Permalink
Guenther Niess added a comment -

After the successfully tests of wroot and a secound review I committed the patch to r11194.

Show
Guenther Niess added a comment - After the successfully tests of wroot and a secound review I committed the patch to r11194.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.