[patch] Prepend string to broadcast messages

Details

  • Type: New Feature New Feature
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

http://www.igniterealtime.org/community/message/168856

I've attached a patch that allows prepending broadcast messages with an administrator defined string. I've chosen plugin.broadcast.messagePrefix as the name for the new property associated with this. If this property is not set then broadcast messages are not modified.

Example:

plugin.broadcast.messagePrefix = "(broadcast) "

Sending message "who ate my lunch?" to all@broadcast.domain results in all recipients receiving "(broadcast) who ate my lunch?".

I hope this proves to be useful for others.

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. SPARK-1188 Emphasize broadcast message in the chat window

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gaston Dombiak added a comment -

Nice improvement. There already exists 4 other properties so with this one we are now in 5. I think that it is now time to create a new page where admins can configure these properties (maybe not include the servicename). Anyone willing to add this page? I think that it will simplify administration of this very popular plugin.

Show
Gaston Dombiak added a comment - Nice improvement. There already exists 4 other properties so with this one we are now in 5. I think that it is now time to create a new page where admins can configure these properties (maybe not include the servicename). Anyone willing to add this page? I think that it will simplify administration of this very popular plugin.
Hide
Permalink
LG added a comment -

Hi Gato,

are we rejecting updates/patches unless a web gui for the broadcast plugin is created? I would like to see this patch applied and the issue closed. We can create a new issue "Web GUI for Broadcast Plugin" and solve it independently.

LG

Show
LG added a comment - Hi Gato, are we rejecting updates/patches unless a web gui for the broadcast plugin is created? I would like to see this patch applied and the issue closed. We can create a new issue "Web GUI for Broadcast Plugin" and solve it independently. LG
Hide
Permalink
LG added a comment -

Any idea why a loop and FlyweightText is used within the patch instead of
"message.setBody(messagePrefix + " " + message.getBody());"?

Show
LG added a comment - Any idea why a loop and FlyweightText is used within the patch instead of "message.setBody(messagePrefix + " " + message.getBody());"?
Hide
Permalink
LG added a comment -

minor change. It has no effect as long as the new property is not set.

Show
LG added a comment - minor change. It has no effect as long as the new property is not set.
Hide
Permalink
wroot added a comment -

This is not working for me with 3.7.0 Beta.

Show
wroot added a comment - This is not working for me with 3.7.0 Beta.

People

  • Assignee:
    Daryl Herzmann
    Reporter:
    Daryl Herzmann
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: