Openfire (ARCHIVED)

Improve i18n in plugin admin console pages

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1.0 Beta 2
  • Fix Version/s: 3.5.0
  • Component/s: Admin Console
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

i18n lookups in plugin JSP pages should be cascading – check for the key in the plugin i18n file and then if that fails, look for it in the Wildfire bundle. This is required since certain strings are used in the decorator of each page such as login.title. The current workaround is to copy those strings into the plugin i18n file.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Henninger added a comment -

Committed a partial fix that eliminates the need for plugins to have things like login.title in their own resource configs. However, it does not solve the issue of plugins that want to reuse global strings in their own pages.

Show
Daniel Henninger added a comment - Committed a partial fix that eliminates the need for plugins to have things like login.title in their own resource configs. However, it does not solve the issue of plugins that want to reuse global strings in their own pages.
Hide
Permalink
Daniel Henninger added a comment -

I'm generally of a feeling that yes it's nice to reuse strings from openfire itself, but I think it's actually better for plugins to set all of their own strings, just in case Openfire needs to make some adjustments. That said, we have implemented the necessary functionality to make it so plugins don't have to have login.title and other things that are part of the mesh that don't belong to the plugin itself, so I think that will take care of the real issue. =) If you disagree, let me know!

Show
Daniel Henninger added a comment - I'm generally of a feeling that yes it's nice to reuse strings from openfire itself, but I think it's actually better for plugins to set all of their own strings, just in case Openfire needs to make some adjustments. That said, we have implemented the necessary functionality to make it so plugins don't have to have login.title and other things that are part of the mesh that don't belong to the plugin itself, so I think that will take care of the real issue. =) If you disagree, let me know!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.