Openfire (ARCHIVED)

sslEnabled in HttpBindManager always false at boot, causing httpbind not to start

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.6.1
  • Fix Version/s: 3.6.2
  • Component/s: None
  • Acceptance Test - Add?:
    No
  • Description:

    1) Start openfire
    2) Check httpbind settings, https port is 0
    3) set it to some other port, https httpbind starts up
    4) shut down openfire
    5) start up openfire, httpbind is not running

    will investigate more.

Activity

Hide
Daryl Herzmann added a comment - 11/18/08 07:12 AM

Hi,

I think I figured out the bug, but I may be off the base.

in HttpBindManager.java

the sslEnabled variable only has the chance to be set true when configureHttpBindServer is called. Otherwise, it will always be false and thus getHttpBindSecurePort will always return 0 , which will cause start() to fail, since configureHttpBindServer is called after getHttpBindSecurePort()

Will think some more about a patch for this.

daryl

Show
Daryl Herzmann added a comment - 11/18/08 07:12 AM Hi, I think I figured out the bug, but I may be off the base. in HttpBindManager.java the sslEnabled variable only has the chance to be set true when configureHttpBindServer is called. Otherwise, it will always be false and thus getHttpBindSecurePort will always return 0 , which will cause start() to fail, since configureHttpBindServer is called after getHttpBindSecurePort() Will think some more about a patch for this. daryl
Daryl Herzmann made changes - 11/18/08 07:12 AM
Field Original Value New Value
Fix Version/s 3.6.2 [ 10832 ]
Daryl Herzmann made changes - 11/18/08 07:18 AM
Description 1) Start openfire
2) Check httpbind settings, https port is 0
3) set it to some other port, https httpbind starts up
4) shut down openfire
5) start up openfire, httpbind https is not running

will investigate more.
1) Start openfire
2) Check httpbind settings, https port is 0
3) set it to some other port, https httpbind starts up
4) shut down openfire
5) start up openfire, httpbind is not running

will investigate more.
Summary Something prevents https httpbind from starting up in some cases sslEnable in HttpBindManager always false at boot, causing httpbind not to start
Daryl Herzmann made changes - 11/18/08 07:19 AM
Summary sslEnable in HttpBindManager always false at boot, causing httpbind not to start sslEnabled in HttpBindManager always false at boot, causing httpbind not to start
Hide
Daryl Herzmann added a comment - 11/18/08 07:22 AM

Bug appears to be introduced with this changeset.

http://www.igniterealtime.org/fisheye/changelog/svn-org?cs=10596

I am not sure what Clearspace needs for a port number return when https bind is disabled and if reverting parts of this patch break what CS wants. sorry

daryl

Show
Daryl Herzmann added a comment - 11/18/08 07:22 AM Bug appears to be introduced with this changeset. http://www.igniterealtime.org/fisheye/changelog/svn-org?cs=10596 I am not sure what Clearspace needs for a port number return when https bind is disabled and if reverting parts of this patch break what CS wants. sorry daryl
Gaston Dombiak made changes - 11/20/08 10:02 AM
Status Open [ 1 ] In Progress [ 3 ]
Gaston Dombiak made changes - 11/20/08 10:12 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Closed [ 6 ]

People

Dates

  • Created:
    11/18/08 06:48 AM
    Updated:
    11/20/08 10:12 AM
    Resolved:
    11/20/08 10:12 AM