Openfire (ARCHIVED)

fix tablename for ofMucaffiliation

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 3.6.0
  • Fix Version/s: 3.6.1
  • Component/s: Groupchat
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

case bug with MUCPersistenceManager.java

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Horwitz added a comment -

relevent lines from at least one of the cases that throws this:

at $java.sql.PreparedStatement$$EnhancerByProxool$$a8cf99df.executeUpdate(<generated>)
at org.jivesoftware.openfire.muc.spi.MUCPersistenceManager.removeAffiliationFromDB(MUCPersistenceManager.java:956)
at org.jivesoftware.openfire.muc.MultiUserChatManager.userDeleting(MultiUserChatManager.java:835)
at org.jivesoftware.openfire.event.UserEventDispatcher.dispatchEvent(UserEventDispatcher.java:124)
at org.jivesoftware.openfire.user.UserManager.deleteUser(UserManager.java:188)
at org.jivesoftware.openfire.admin.user_002ddelete_jsp._jspService(user_002ddelete_jsp.java:93)

This will affect at least all users of mysql on *nix platforms

Show
David Horwitz added a comment - relevent lines from at least one of the cases that throws this: at $java.sql.PreparedStatement$$EnhancerByProxool$$a8cf99df.executeUpdate(<generated>) at org.jivesoftware.openfire.muc.spi.MUCPersistenceManager.removeAffiliationFromDB(MUCPersistenceManager.java:956) at org.jivesoftware.openfire.muc.MultiUserChatManager.userDeleting(MultiUserChatManager.java:835) at org.jivesoftware.openfire.event.UserEventDispatcher.dispatchEvent(UserEventDispatcher.java:124) at org.jivesoftware.openfire.user.UserManager.deleteUser(UserManager.java:188) at org.jivesoftware.openfire.admin.user_002ddelete_jsp._jspService(user_002ddelete_jsp.java:93) This will affect at least all users of mysql on *nix platforms
Hide
Permalink
David Horwitz added a comment -

Patch for this issue:

      1. Eclipse Workspace Patch 1.0
        #P openfire
        Index: src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java
        ===================================================================
      • src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (revision 10828)
        +++ src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (working copy)
        @@ -112,7 +112,7 @@
        private static final String DELETE_USER_MEMBER =

"DELETE FROM ofMucMember WHERE jid=?";

private static final String DELETE_USER_MUCAFFILIATION =

  • "DELETE FROM ofMucaffiliation WHERE jid=?";

+ "DELETE FROM ofMucAffiliation WHERE jid=?";

private static final String ADD_CONVERSATION_LOG =

"INSERT INTO ofMucConversationLog (roomID,sender,nickname,logTime,subject,body) " +

"VALUES (?,?,?,?,?,?)";

Show
David Horwitz added a comment - Patch for this issue:
      1. Eclipse Workspace Patch 1.0 #P openfire Index: src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java ===================================================================
      • src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (revision 10828) +++ src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (working copy) @@ -112,7 +112,7 @@ private static final String DELETE_USER_MEMBER =
"DELETE FROM ofMucMember WHERE jid=?"; private static final String DELETE_USER_MUCAFFILIATION =
  • "DELETE FROM ofMucaffiliation WHERE jid=?";
+ "DELETE FROM ofMucAffiliation WHERE jid=?"; private static final String ADD_CONVERSATION_LOG = "INSERT INTO ofMucConversationLog (roomID,sender,nickname,logTime,subject,body) " + "VALUES (?,?,?,?,?,?)";
Hide
Permalink
Daryl Herzmann added a comment -

Thanks David, your patch matches mine attached to the ticket

Show
Daryl Herzmann added a comment - Thanks David, your patch matches mine attached to the ticket
Hide
Permalink
David Horwitz added a comment -

doh missed that - so used to not having permission to attach files in this jira I forget to look for them

Show
David Horwitz added a comment - doh missed that - so used to not having permission to attach files in this jira I forget to look for them
Hide
Permalink
Daryl Herzmann added a comment -

This bug is trivial , assigning as blocker

Show
Daryl Herzmann added a comment - This bug is trivial , assigning as blocker

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.